Missing plugin unit test coverage for allowed_address_pairs

Bug #1255150 reported by Salvatore Orlando
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Medium
Jon Grimm

Bug Description

Some plugins, at least openvswitch and ml2, are not inheriting the test case for allowed address pairs.

This means that the bits related to address pairs use cases in these plugins are currently not covered by unit tests.

Jon Grimm (jgrimm)
Changed in neutron:
assignee: nobody → Jon Grimm (jgrimm)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (master)

Fix proposed to branch: master
Review: https://review.openstack.org/58847

Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/58896

Akihiro Motoki (amotoki)
tags: added: ml2 nec ovs
Changed in neutron:
milestone: none → icehouse-3
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/58847
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=2cbded6e836e0b20b23384eb26252eda58298259
Submitter: Jenkins
Branch: master

commit 2cbded6e836e0b20b23384eb26252eda58298259
Author: Jon Grimm <email address hidden>
Date: Wed Nov 27 13:10:33 2013 -0600

    Openvswitch update_port should return updated port info

    Found when I enabled test_extension_allowedaddress_pairs, where
    test_create_port_removed_allowed_address_pairs would fail due to the
    returned port still containing the original addresspair. The cause is
    ovs simply not updating the port info being returned.

    This patch additionally enables test_extension_allowedaddress_pairs for
    openvswitch.

    Moved checks and updating into method similar to what we do for
    extradhcpopts and security_groups.

    Additionally, this required fixing is_address_pairs_attribute_updated() as
    it was passing (non-hashable) dicts to utils.compare_elements.

    Change-Id: Ic871fea68fb9fcc862b1fd5ae5fe7aec540e4a30
    Partial-Bug: #1255150

Thierry Carrez (ttx)
Changed in neutron:
milestone: icehouse-3 → icehouse-rc1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/58896
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=7599d9d0526e22977caf6de13c751884a5d8f2f5
Submitter: Jenkins
Branch: master

commit 7599d9d0526e22977caf6de13c751884a5d8f2f5
Author: Jon Grimm <email address hidden>
Date: Wed Nov 27 18:34:45 2013 -0600

    Fix ml2 & nec plugins for allowedaddresspairs tests

    Enabling the allowedaddresspairs tests uncovered that update_port()
    was not returning the expected updated port info (still contained
    original info).

    Change-Id: I88f252e1348d272edd114fbee69e2309d3740213
    Closes-bug: #1255150

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in neutron:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.