security group update notification sent twice

[Salvatore Orlando]

For several plugins the security group update notification on port-update is sent twice.

1) https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/plugin.py#L634
2) https://github.com/openstack/neutron/blob/master/neutron/db/securitygroups_rpc_base.py#L101

the notification at #1 is sent but not that at #2 if the security group on the port was not updated.
However if the notication at #2 is sent, then the notification at #1 will always be sent too.

Therefore the notification at #2 is probably redundant

This affects at least the following plugins:
- nec
- ryu
- linuxbridge
- openvswitch
- ryu

This causes a lot more traffic on the agent side thus slowing all the operations on the agent, including wiring VIF ports.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/58415

[yong sheng gong (gongysh)]

https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/plugin.py#L634
will send port_update message to agent,
but https://github.com/openstack/neutron/blob/master/neutron/db/securitygroups_rpc_base.py#L101
sends security_groups_member_updated or security_groups_provider_updated.

These messages are very differently dealt on agent side. are u sure they are redundant?

[Salvatore Orlando (salvatore-orlando)]

The handler port_update refreshes also the security group if the port has a security group configured.

Feel free to mark the bug as invalid if you feel we need to send two messages for each update_port operation.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/58415
Committed: http://github.com/openstack/neutron/commit/09c3051fb2819b647f4d8196e6e0fbc66f0ccc04
Submitter: Jenkins
Branch: master

commit 09c3051fb2819b647f4d8196e6e0fbc66f0ccc04
Author: Salvatore Orlando <email address hidden>
Date: Mon Nov 25 16:25:43 2013 -0800

    Send only one agent notification on port update

    This patch removes the other redundant notification sent in the same
    routine to notify whether a security group changed.

    Closes-Bug: #1254924
    Partial Blueprint neutron-tempest-parallel

    Change-Id: I5bad015decdc197c3fa9b58c680564380d513bc4