Deprecate and remove libvirt.api_thread_pool option

Bug #1254811 reported by Matt Riedemann
16
This bug affects 3 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Unassigned

Bug Description

We should deprecate the libvirt.api_thread_pool config option in icehouse and remove it in the J release. Looks like the last time it was touched was in January for some refactoring:

https://github.com/openstack/nova/commit/ce27bca5497600ff9ab7195e27ede94e7cffe5d0

The reasons why this should be removed are detailed here:

https://review.openstack.org/#/c/57000

Tags: libvirt
Michael Still (mikal)
Changed in nova:
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/59941
Committed: http://github.com/openstack/nova/commit/22cd7cc27ca8285c1674e370e256ec84d3f2a20a
Submitter: Jenkins
Branch: master

commit 22cd7cc27ca8285c1674e370e256ec84d3f2a20a
Author: Michael Kerrin <email address hidden>
Date: Mon Nov 25 11:03:26 2013 +0000

    Remove the api_thread_pool option from libvirt driver

    This gave us the option to select if calls to libvirtd are done
    in a native thread or directly. This was added because the person
    who wrote the thread pool code was afraid of regressions for existing
    deployments. But now we have enough features in nova that require
    that this is always set to True or else users can have issues with
    them. To this point the firewall overrode this option to make
    sure that its call was always in a native thread no matter the
    value of this option was.

    The reasons behind this were discussed during this review:
    https://review.openstack.org/#/c/57000/

    Closes-Bug: #1254811

    DocImpact: removes api_thread_pool flag from the libvirt group

    Change-Id: Ifad7f1bdf2af69e4fcd6f9a04bf2f7ff5251afd6

Changed in nova:
status: Triaged → Fix Committed
Changed in nova:
milestone: none → icehouse-2
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.