The param 'readonly' for os-update_readonly_flag incorrectly checked

Bug #1254682 reported by zhangyanzi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Low
zhangyanzi

Bug Description

In the function os-update_readonly_flag, the param 'readonly' should be needed as a positional argument.
But it does not check the KeyError.

zhangyanzi (zhangyanzi)
Changed in cinder:
assignee: nobody → zhangyanzi (zhangyanzi)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/58261

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/58261
Committed: http://github.com/openstack/cinder/commit/f1cc8726058a5b3bc4b955e3441e498c2ead8471
Submitter: Jenkins
Branch: master

commit f1cc8726058a5b3bc4b955e3441e498c2ead8471
Author: zhangyanzi <email address hidden>
Date: Mon Nov 25 19:33:49 2013 +0800

    The param 'readonly' is incorrect checked

    In the function os-update_readonly_flag, the param 'readonly' is incorrect
    checked, without the param in request, i think it should raise exception
    with message like "Must specify readonly in request."

    Change-Id: I19e15e988ffa2d093d374f6a33ce94d45ffe2c30
    Closes-bug: 1254682

Changed in cinder:
status: In Progress → Fix Committed
Changed in cinder:
milestone: none → icehouse-1
importance: Undecided → Low
Thierry Carrez (ttx)
Changed in cinder:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.