OpenStack DBaaS (Trove)

_create_server_volume_heat signature contains unused security_groups argument

Bug #1254607 reported by Sushil Kumar
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack DBaaS (Trove)
Fix Released
Undecided
Sushil Kumar
OpenStack DBaaS (Trove) 2014.1 "icehouse"

Bug Description

_create_server_volume_heat method in trove.taskmanager.models has a parameter security_groups in its signature which is no-where used in implementation.
Also the comment says

        # Heat based orchestration handles security group(resource)
        # in the template defination.
So, we do not need that parameter in the _create_server_volume_heat signature as well as call.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to trove (master)

Fix proposed to branch: master
Review: https://review.openstack.org/58203

Changed in trove:
assignee: nobody → Sushil Kumar (sushil-kumar2)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to trove (master)

Reviewed: https://review.openstack.org/58203
Committed: http://github.com/openstack/trove/commit/d66c411fa7f57f364d283b2236ba272f9669cbfb
Submitter: Jenkins
Branch: master

commit d66c411fa7f57f364d283b2236ba272f9669cbfb
Author: Sushil Kumar <email address hidden>
Date: Mon Nov 25 07:10:27 2013 +0000

    Removes security_groups from _create_server_volume_heat signature

    Closes-Bug: #1254607

    Change-Id: I22b6af351dd3a371443f432c01785c706eff8397

Changed in trove:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in trove:
milestone: none → icehouse-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in trove:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.