Go OpenStack Exchange

launchpad.net/goose/... tests fail with gccgo

Bug #1254564 reported by Michael Hudson-Doyle
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Go OpenStack Exchange
Fix Released
High
Unassigned
juju-core
Fix Released
High
Unassigned
juju-core 1.17.0

Bug Description

As attached.

Related branches

lp:~mwhudson/goose/gccgo-compat
Dave Cheney (community): Approve
John A Meinel: Approve
Diff: 78 lines (+38/-5)
2 files modified
nova/nova.go (+10/-2)
testservices/hook/service.go (+28/-3)
lp:~dave-cheney/goose/goose
Ready for review for merging into lp:goose
Michael Hudson-Doyle: Approve
John A Meinel: Approve
Diff: 48 lines (+3/-6)
3 files modified
nova/local_test.go (+1/-2)
testservices/novaservice/service_http.go (+1/-1)
testservices/service.go (+1/-3)
lp:~dave-cheney/goose/001-move-gccgo-specific-code-to-individual
Juju Engineering: Pending requested
Diff: 133 lines (+61/-46)
3 files modified
testservices/hook/service.go (+0/-46)
testservices/hook/service_gc.go (+24/-0)
testservices/hook/service_gccgo.go (+37/-0)
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :
Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

I think this is mostly because testservices/hook/service.go:currentServiceMethodName doesn't work as expected with gccgo, which means the RegisterControlPoint machinery doesn't work and so all of the test double insertion that the test suite relies upon doesn't happen.

Revision history for this message
Dave Cheney (dave-cheney) wrote :

Bug raised upstream for runtime.Caller inconsistency

https://code.google.com/p/go/issues/detail?id=6835

Revision history for this message
Dave Cheney (dave-cheney) wrote :

All branches have landed in goose, revno 112 or later should be used by Juju

Changed in goose:
status: New → Fix Committed
importance: Undecided → Medium
Changed in juju-core:
status: New → Fix Committed
importance: Undecided → Medium
milestone: none → 1.17.1
Revision history for this message
Dave Cheney (dave-cheney) wrote :

Sorry, make that revno 113

Curtis Hovey (sinzui)
Changed in juju-core:
importance: Medium → High
Changed in goose:
importance: Medium → High
John A Meinel (jameinel)
Changed in juju-core:
milestone: 1.17.1 → 1.17.0
Curtis Hovey (sinzui)
Changed in goose:
status: Fix Committed → Fix Released
Curtis Hovey (sinzui)
Changed in juju-core:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.