No need to mark lang name in LANGUAGES in settings.py translatable

Bug #1254488 reported by Akihiro Motoki
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Wishlist
Peter Belanyi

Bug Description

Language names in LANGUAGES list in openstack_dashboard/settings.py are marked as translatable, but there is no need to mark them as translatable.

https://github.com/openstack/horizon/blob/master/openstack_dashboard/settings.py#L176

- Language names displayed in the user settings panel are actually extracted from django.conf.locale.__init__ and these strings are not referred (as long as languages are defined in django).
- Even when a language is not defined in django, there is no need the language is displayed as translated string because a user of some language cannot understand the translated string if another language is displayed in the lang menu.

I would like to suggest to remove "gettext_noop".

Changed in horizon:
status: New → Confirmed
Annapoornima (a-koppad)
Changed in horizon:
assignee: nobody → Annapoornima (a-koppad)
Revision history for this message
Julie Pichon (jpichon) wrote :

Unassigning due to inactivity.

Changed in horizon:
assignee: Annapoornima (a-koppad) → nobody
Peter Belanyi (pbelanyi)
Changed in horizon:
assignee: nobody → Peter Belanyi (pbelanyi)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/77941

Changed in horizon:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/77941
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=9726f596f3255f15573ba34390eb042297f4073e
Submitter: Jenkins
Branch: master

commit 9726f596f3255f15573ba34390eb042297f4073e
Author: Peter Belanyi <email address hidden>
Date: Tue Mar 4 17:31:40 2014 +0100

    Remove gettext_noop from language list

    Language names in LANGUAGES list are marked as translatable,
    but it is unnecessary, so this change removes gettext_noop.

    Change-Id: I8f8dd9d16daebf8fec6ecb3f9191ece05c3ceead
    Closes-Bug: #1254488

Changed in horizon:
status: In Progress → Fix Committed
Akihiro Motoki (amotoki)
Changed in horizon:
milestone: none → icehouse-rc1
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: icehouse-rc1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.