Heat Stack name not validated

Bug #1254212 reported by Leandro Ignacio Costantino
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Undecided
Leandro Ignacio Costantino

Bug Description

When creating a new stack, if the name does not start with [a-zA-Z] the creation fails with a generic message.

Ideally, we should add the same regexp used in Heat into the form to avoid an extra request just to fail and improve the error message.

Steps:
  1) Stack
  2) Create Stack ( use minimum template example )
  3) Name:
         2222_Stack or _Stack or ...Stack

Changed in horizon:
assignee: nobody → Leandro Ignacio Costantino (leandro-i-costantino)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/58068

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/58068
Committed: http://github.com/openstack/horizon/commit/fd67686e1fe8147847d9580c6c327ce812b56a22
Submitter: Jenkins
Branch: master

commit fd67686e1fe8147847d9580c6c327ce812b56a22
Author: Leandro I. Costantino <email address hidden>
Date: Fri Nov 22 02:55:42 2013 -0500

    Heat Stack name is missing form validation.

    When creating a stack using Horizon, the form is missing name
    validation, so a generic error is shown whenever the name
    does not follow the regex used by Heat.
    ([a-zA-Z][a-zA-Z0-9_.-]*)
    Add server side validation and the right error message.

    Change-Id: I7a639bcf96b7c74760123b6106aab7d9311f5e2f
    Closes-Bug: #1254212

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
milestone: none → icehouse-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.