VMware: NoneType object has no attribute 'state'

[Ryan Hsu]

When running the Tempest test suite with VC Driver, one of the tests failed because an instance failed to build. The error message seen in the log was:

Traceback (most recent call last):
  File "/opt/stack/nova/nova/compute/manager.py", line 1030, in _build_instance
    set_access_ip=set_access_ip)
  File "/opt/stack/nova/nova/compute/manager.py", line 1439, in _spawn
    LOG.exception(_('Instance failed to spawn'), instance=instance)
  File "/opt/stack/nova/nova/compute/manager.py", line 1436, in _spawn
    block_device_info)
  File "/opt/stack/nova/nova/virt/vmwareapi/driver.py", line 624, in spawn
    admin_password, network_info, block_device_info)
  File "/opt/stack/nova/nova/virt/vmwareapi/vmops.py", line 431, in spawn
    upload_folder, upload_name + ".vmdk")):
  File "/opt/stack/nova/nova/virt/vmwareapi/vmops.py", line 1523, in _check_if_folder_file_exists
    file_name)
  File "/opt/stack/nova/nova/virt/vmwareapi/vmops.py", line 1486, in _path_file_exists
    if task_info.state in ['queued', 'running']:
AttributeError: 'NoneType' object has no attribute 'state'

This seems to be a rare intermittent failure as we were not able to reproduce it again (this happened in VMware Minesweeper).

All screen log files are available here: http://162.209.83.206/logs/52687/3/

[Gary Kotton (garyk)]

I saw this problem over the weekend.
I have addressed it with: https://review.openstack.org/58142

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/63933
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=bf882fbc4aa68cf0191bce70e622d81969617c02
Submitter: Jenkins
Branch: master

commit bf882fbc4aa68cf0191bce70e622d81969617c02
Author: Gary Kotton <email address hidden>
Date: Tue Dec 24 06:19:26 2013 -0800

    VMware: create datastore utility functions

    The patch moves datastore interfaces from vmops and vm_util
    to a separate file - ds_util.

    This is part of the blueprint vmware-image-cache-management.

    In the past the datastore methods would poll the task
    to determine that it had completed. This has beem addressed by
    making the driver _poll_task return the task information.

    The patch set also solves the following bugs by checking if
    the FileAlreadyExistsException exception is raised. This could
    be due to another process or thread creating the file.

    Closes-bug: 1230047
    Closes-bug: 1254128

    Change-Id: I788e33dbcb3dedc41831b976137607274b1c02ca