Subnet / Subnet details not marked as translatable

Bug #1254026 reported by Julie Pichon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Yidan Zhang
Havana
Fix Released
Low
Akihiro Motoki

Bug Description

When trying to create or update a subnet from the Networks details page, the tab titles 'Subnet' and 'Subnet details' are not showing as translated.

This is because when defining the names, the leading underscore were missed in several places in order to mark the string as translatable, cf. https://git.openstack.org/cgit/openstack/horizon/tree/openstack_dashboard/dashboards/project/networks/subnets/workflows.py

Steps to reproduce:
1. On the left side panel, select the Networks menu.
2. Click on a network name to open the Network Details page.
3. Click the "Create Subnet" or "Edit Subnet" button and check the tabs

Julie Pichon (jpichon)
tags: added: havana-backport-potential
Changed in horizon:
assignee: nobody → Yidan Zhang (zhangyidan2008)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/57950

Changed in horizon:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/57950
Committed: http://github.com/openstack/horizon/commit/599c2135e5dfdcf88324faf1a8336a252db72d2f
Submitter: Jenkins
Branch: master

commit 599c2135e5dfdcf88324faf1a8336a252db72d2f
Author: Yidan Zhang <email address hidden>
Date: Fri Nov 22 23:18:32 2013 +0800

    translate text: "subnet"/"subnet details"

    When trying to create or update a subnet from the Networks
    details page, the tab titles 'Subnet' and 'Subnet details'
    are not showing as translated. This patch add the missing
    underscore.

    Change-Id: I48cd47e7ead3717d96e4808f41bf876a567c8052
    Closes-Bug: #1254026

Changed in horizon:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/havana)

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/58184

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (stable/havana)

Reviewed: https://review.openstack.org/58184
Committed: http://github.com/openstack/horizon/commit/728b5d1865b48d6d3398aa09cc1585c0a51bd2a8
Submitter: Jenkins
Branch: stable/havana

commit 728b5d1865b48d6d3398aa09cc1585c0a51bd2a8
Author: Yidan Zhang <email address hidden>
Date: Fri Nov 22 23:18:32 2013 +0800

    translate text: "subnet"/"subnet details"

    When trying to create or update a subnet from the Networks
    details page, the tab titles 'Subnet' and 'Subnet details'
    are not showing as translated. This patch add the missing
    underscore.

    Change-Id: I48cd47e7ead3717d96e4808f41bf876a567c8052
    Closes-Bug: #1254026
    (cherry picked from commit 599c2135e5dfdcf88324faf1a8336a252db72d2f)

tags: added: in-stable-havana
Julie Pichon (jpichon)
Changed in horizon:
milestone: none → icehouse-1
Akihiro Motoki (amotoki)
tags: removed: havana-backport-potential
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Alan Pevec (apevec)
tags: removed: in-stable-havana
Thierry Carrez (ttx)
Changed in horizon:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.