API returns unicode Location Header

Bug #1254017 reported by Alvaro Lopez
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Medium
Alvaro Lopez

Bug Description

The API is returning some headers encoded as a unicode string, instead of utf8 (against RFC for HTTP). This causes troubles when using nova behind Apache, for example.

This could be considered a duplicate of https://bugs.launchpad.net/nova/+bug/938114 but in a different point in the code.

I will try to submit a patch for this, as well as a check for the headers not being Unicode.

Alvaro Lopez (aloga)
Changed in nova:
assignee: nobody → Alvaro Lopez (aloga)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/58523

Andrew Laski (alaski)
Changed in nova:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/58523
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=148b6458642e810f57f9f85818b415e4029cb439
Submitter: Jenkins
Branch: master

commit 148b6458642e810f57f9f85818b415e4029cb439
Author: Alvaro Lopez Garcia <email address hidden>
Date: Mon Nov 25 17:50:30 2013 +0100

    Ensure that headers are utf8, not unicode

    Although the api.openstack.wsgi.ResponseObject converted the headers to
    utf8 strings to comply with RFC for HTTP this was not enough, since some
    responses that contained unicode strings were returned, causing an error
    when running nova behind an http server like Apache. This change ensures
    that headers are always an utf8 encoded string.

    Closes-Bug: 1254017

    Change-Id: I980326f1f15907bf57060acdd132011254289079

Changed in nova:
status: In Progress → Fix Committed
Changed in nova:
milestone: none → icehouse-3
Thierry Carrez (ttx)
Changed in nova:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-3 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.