'GetWindowVersion' was not declared in this scope

[Matthias Mailänder]

Tried to update https://build.opensuse.org/package/show/home:Mailaender:branches:games/s25rttr However the build fails:

/home/abuild/rpmbuild/BUILD/s25rttr-0.8.1/liblobby/src/LobbyClient.cpp: In member function 'void LobbyClient::AddServer(std::string, std::string, bool, short unsigned int)':
/home/abuild/rpmbuild/BUILD/s25rttr-0.8.1/liblobby/src/LobbyClient.cpp:294:37: error: 'GetWindowVersion' was not declared in this scope
  server.setVersion(GetWindowVersion());
                                     ^
/home/abuild/rpmbuild/BUILD/s25rttr-0.8.1/liblobby/src/LobbyClient.cpp: In member function 'virtual void LobbyClient::OnNMSLobbyID(unsigned int, const unsigned int&)':
/home/abuild/rpmbuild/BUILD/s25rttr-0.8.1/liblobby/src/LobbyClient.cpp:408:90: error: 'GetWindowVersion' was not declared in this scope
    send_queue.push(new LobbyMessage_Login(userdata.user, userdata.pass, GetWindowVersion()));
                                                                                          ^
make[2]: *** [liblobby/src/CMakeFiles/lobby_c.dir/LobbyClient.cpp.o] Error 1
make[1]: *** [liblobby/src/CMakeFiles/lobby_c.dir/all] Error 2

Also some more compiler warnings:

[ 6%] Building CXX object driver/audio/SDL/src/CMakeFiles/audioSDL.dir/SDL.cpp.o
/home/abuild/rpmbuild/BUILD/s25rttr-0.8.1/driver/audio/SDL/src/SDL.cpp: In member function 'virtual Sound* AudioSDL::LoadEffect(unsigned int, unsigned char*, long unsigned int)':
/home/abuild/rpmbuild/BUILD/s25rttr-0.8.1/driver/audio/SDL/src/SDL.cpp:178:10: warning: converting 'false' to pointer type 'Sound*' [-Wconversion-null]
   return false;
          ^
/home/abuild/rpmbuild/BUILD/s25rttr-0.8.1/driver/audio/SDL/src/SDL.cpp:184:10: warning: converting 'false' to pointer type 'Sound*' [-Wconversion-null]
   return false;
          ^
/home/abuild/rpmbuild/BUILD/s25rttr-0.8.1/driver/audio/SDL/src/SDL.cpp:187:10: warning: converting 'false' to pointer type 'Sound*' [-Wconversion-null]
   return false;
          ^
/home/abuild/rpmbuild/BUILD/s25rttr-0.8.1/driver/audio/SDL/src/SDL.cpp:194:10: warning: converting 'false' to pointer type 'Sound*' [-Wconversion-null]
   return false;
          ^
/home/abuild/rpmbuild/BUILD/s25rttr-0.8.1/driver/audio/SDL/src/SDL.cpp: In member function 'virtual Sound* AudioSDL::LoadMusic(unsigned int, unsigned char*, long unsigned int)':
/home/abuild/rpmbuild/BUILD/s25rttr-0.8.1/driver/audio/SDL/src/SDL.cpp:236:10: warning: converting 'false' to pointer type 'Sound*' [-Wconversion-null]
   return false;
          ^
/home/abuild/rpmbuild/BUILD/s25rttr-0.8.1/driver/audio/SDL/src/SDL.cpp:241:10: warning: converting 'false' to pointer type 'Sound*' [-Wconversion-null]
   return false;
          ^
/home/abuild/rpmbuild/BUILD/s25rttr-0.8.1/driver/audio/SDL/src/SDL.cpp:269:10: warning: converting 'false' to pointer type 'Sound*' [-Wconversion-null]
   return false;
          ^
/home/abuild/rpmbuild/BUILD/s25rttr-0.8.1/driver/audio/SDL/src/SDL.cpp:272:10: warning: converting 'false' to pointer type 'Sound*' [-Wconversion-null]
   return false;
          ^

[FloSoft (flosoft)]

fixed in rev9016

[Matthias Mailänder (mailaender)]

Wow that was fast. Can I just package rev9016 as 0.8.1 or will this desync with others?

[Matthias Mailänder (mailaender)]

Note: r9016 is r9015 on http://bazaar.launchpad.net/~flosoft/s25rttr/0.8/ Does bzr support proper tags like git?

[FloSoft (flosoft)]

oh 9015 is correct - not 9016

so it should not desync with others.

I dont know if bazaar knows about tags, I hate bazaar anyway. We use an svn internal so ... I wanted to change to git(hub) for long time already, but the conversion's not as easy as I want it to be :/

[Matthias Mailänder (mailaender)]

Have a look at http://www.vogella.com/articles/Git/article.html#svn_migration maybe it helps.

[FloSoft (flosoft)]

I know that, but here the (svn)repository structure is a bit different and much more complicated and I want to transfer it the "right" way

[Matthias Mailänder (mailaender)]

https://build.opensuse.org/request/show/208074