pt-table-checksum max load 20% rounds down
Bug #1253872 reported by
Rob Smith
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Percona Toolkit moved to https://jira.percona.com/projects/PT |
Fix Released
|
Low
|
Frank Cizmich | ||
Bug Description
When running pt-table-checksum or pt-online-schema on a server that is unused, setting the 20% max load fails due to it rounding down.
Example:
threads_running = 4
threads_running + 20% = 4.8
max_load == threads_running == 4
I purpose that this round up so it will run until max_threads are >=5 rather then the current 4.
What I would actually like to do is say:
max-load is 25 or 120% of threads_running, whichever is greater
Related branches
lp:~percona-toolkit-dev/percona-toolkit/pt-table-checksum-max-load-20-percent-rounds-down-1253872
- Daniel Nichter: Approve
-
Diff: 213 lines (+32/-24)9 files modifiedbin/pt-online-schema-change (+3/-2)
bin/pt-table-checksum (+3/-2)
lib/MySQLStatusWaiter.pm (+3/-2)
t/lib/MySQLStatusWaiter.t (+18/-14)
t/pt-table-checksum/basics.t (+1/-0)
t/pt-table-checksum/samples/default-results-5.5.txt (+1/-1)
t/pt-table-checksum/samples/default-results-5.6.txt (+1/-1)
t/pt-table-checksum/samples/static-chunk-size-results-5.5.txt (+1/-1)
t/pt-table-checksum/samples/static-chunk-size-results-5.6.txt (+1/-1)
| Changed in percona-toolkit: | |
| status: | New → Fix Committed |
| importance: | Undecided → Low |
| milestone: | none → 2.2.10 |
| assignee: | nobody → Frank Cizmich (frank-cizmich) |
Revision history for this message
| Frank Cizmich (frank-cizmich) wrote | #1 |
| Changed in percona-toolkit: | |
| status: | Fix Committed → Fix Released |
Revision history for this message
| Shahriyar Rzayev (rzayev-sehriyar) wrote | #2 |
To post a comment you must log in.
Quick fix committed. Simply rounds up final value for now.