Move some libvirt specific flags into a group

Bug #1253812 reported by OpenStack Infra
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
openstack-manuals
Fix Released
Medium
Summer Long

Bug Description

https://review.openstack.org/55492
commit 6c8ae5ea0ffa7022ef5455a124b86b558ae57f54
Author: Michael Still <email address hidden>
Date: Tue Nov 5 14:40:00 2013 +1100

    Move some libvirt specific flags into a group

    This is backwards compatible via deprecated groups. This change
    moves the flags defined in nova/virt/libvirt/driver.py into a
    "libvirt" configuration group.

    There are other flags which need to be moved, but this change
    is quite large, so I will handle those in follow up changes.

    Now that the flags in nova/virt/libvirt/driver.py are in a libvirt
    group, we can drop the libvirt_ from in front of many of the flag
    names as well.

    Progresses blueprint libvirt-opts-group.

    DocImpact: the following flags are moved into a "libvirt" flag
    group: rescue_image_id, rescue_kernel_id, rescue_ramdisk_id,
    libvirt_type, libvirt_uri, libvirt_inject_password,
    libvirt_inject_key, libvirt_inject_partition, use_usb_tablet,
    live_migration_uri, live_migration_flag, block_migration_flag,
    live_migration_bandwidth, snapshot_image_format,
    libvirt_vif_driver, libvirt_volume_drivers

    The following flags have had the libvirt_ dropped from the start of
    their flag name now that they are in a flag group:
        libvirt_type (now virt_type)
        libvirt_uri (now conn_uri)
        libvirt_inject_password
        libvirt_inject_key
        libvirt_inject_partition
        libvirt_vif_driver
        libvirt_volume_drivers
        libvirt_disk_prefix
        libvirt_wait_soft_reboot_seconds
        libvirt_non_blocking
        libvirt_cpu_mode
        libvirt_cpu_model
        libvirt_snapshots_directory

    The name for the virt_type flag was influenced by bug 1195361,
    which shows confusion as to what the flag is setting (the
    virtualization type libvirt uses, not the driver libvirt uses
    to achieve that).

    Finally, the flag libvirt.nonblocking has been renamed to
    libvirt.api_thread_pool, which is more descriptive.

    Change-Id: I11e79eb5fd79c459374b9bf04707a4e6d79e993f

Tom Fifield (fifieldt)
Changed in openstack-manuals:
milestone: none → icehouse
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to openstack-manuals (master)

Fix proposed to branch: master
Review: https://review.openstack.org/57825

Changed in openstack-manuals:
assignee: nobody → Stephen Gordon (sgordon)
status: Triaged → In Progress
Michael Still (mikal)
tags: added: team-rcbau
Stephen Gordon (sgordon)
Changed in openstack-manuals:
status: In Progress → Fix Released
Revision history for this message
Summer Long (slong-g) wrote :

The automatic docs were picked up, but looks like there are still mentions in the config ref still using the old terms.

Changed in openstack-manuals:
status: Fix Released → In Progress
assignee: Stephen Gordon (sgordon) → Summer Long (slong-g)
Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/91954

Revision history for this message
Openstack Gerrit (openstack-gerrit) wrote : Fix merged to openstack-manuals (master)

Reviewed: https://review.openstack.org/91954
Committed: https://git.openstack.org/cgit/openstack/openstack-manuals/commit/?id=fa6a754723855f1fb1d768fef9bc6cb1e8a7bf4f
Submitter: Jenkins
Branch: master

commit fa6a754723855f1fb1d768fef9bc6cb1e8a7bf4f
Author: Summer Long <email address hidden>
Date: Sat May 3 21:48:36 2014 +1000

    Fixing deprecated libvirt options for nova.conf

    [DEFAULT] => [libvirt]
    libvirt_type => virt_type
    libvirt_NAME => NAME

    Closes-bug: #1253812

    Change-Id: I154ff62954bda5562f7e9c9ca1e56feecf18faf1

Changed in openstack-manuals:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/openstack-manuals 15.0.0

This issue was fixed in the openstack/openstack-manuals 15.0.0 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.