juju set/unset broken in trunk against 1.16

Bug #1253649 reported by John A Meinel
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
juju-core
Fix Released
High
John A Meinel

Bug Description

juju set calls client.SetConstraints which uses the new Client.NewServiceSetForClientAPI because of the differences in handling of empty strings and null. (We want to support setting a config entry to the empty string, and passing Null to mean it should be reverted to the default value, or use juju unset for that.)

juju unset calls Client.ServiceUnset

However, those API calls weren't available in 1.16 so 1.18 would be incompatible with a 1.16 server.

A possible fix is to localize it in client.SetConstraints. (try the new API fall back to the old one if we can't get the new one, even though it might treat empty strings differently.)

Along the same lines *maybe* "juju unset" could pass the empty string to the old Client.SetConstraints?

part of bug #1253619

Related branches

John A Meinel (jameinel)
summary: - juju set broken in trunk against 1.16
+ juju set/unset broken in trunk against 1.16
description: updated
description: updated
John A Meinel (jameinel)
Changed in juju-core:
assignee: nobody → John A Meinel (jameinel)
status: Triaged → In Progress
John A Meinel (jameinel)
Changed in juju-core:
milestone: 1.17.1 → 1.17.0
Go Bot (go-bot)
Changed in juju-core:
status: In Progress → Fix Committed
Curtis Hovey (sinzui)
Changed in juju-core:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.