The positional arguments of create flavor is incorrect disposal

Bug #1253525 reported by zhangyanzi
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Christopher Yeoh

Bug Description

The positional arguments of create flavor name, ram, vcpus and disk are incorrect disposal.
when i create flavor without name ,
it throws exception with message: "name is not a string or unicode"
but i didn't input name ,
I think it should throw exception with message:
"Invalid request body" or
 "The server could not comply with the request since it is either malformed or otherwise incorrect."

The parameter ram, vcpus and disk have the same problem.

Tags: api
zhangyanzi (zhangyanzi)
Changed in nova:
assignee: nobody → zhangyanzi (zhangyanzi)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/57639

Revision history for this message
Joe Gordon (jogo) wrote :

patch was abandoned, this needs to be re-triaged

Changed in nova:
status: In Progress → New
assignee: zhangyanzi (zhangyanzi) → nobody
Tracy Jones (tjones-i)
tags: added: api
Changed in nova:
status: New → Confirmed
assignee: nobody → Christopher Yeoh (cyeoh-0)
Changed in nova:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/107556

Changed in nova:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/107556
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=eaa90be5ad759919f67c8e586851b8f9fadef580
Submitter: Jenkins
Branch: master

commit eaa90be5ad759919f67c8e586851b8f9fadef580
Author: Chris Yeoh <email address hidden>
Date: Thu Jul 17 14:11:50 2014 +0930

    Check compulsory flavor create parameters exist

    Check that the name, ram, vcpu and disk parameters exist
    in the request for flavor creation in order to be able to
    return a more informative error message to a user when they
    are not supplied.

    Change-Id: I7fd235f8b57e5ecba37e50d6f0ce0a3866c1cd55
    Closes-Bug: 1253525

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → juno-3
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: juno-3 → 2014.2
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.