functional tests use wrong date format

[Mike Barton]

In test/functional/tests.py, the TestFileComparison suite uses "time.asctime(" to format dates in if-modified-since type headers. They should be in HTTP-date or ISO-86601 or whatever format is correct there.

[Greg Lange (greglange)]

This looks serious. If nobody fixes this soon, I'll do it myself.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/57592

[Samuel Merritt (torgomatic)]

From RFC 2216 section 3.3.1 ("Full Date"):

   HTTP applications have historically allowed three different formats
   for the representation of date/time stamps:

      Sun, 06 Nov 1994 08:49:37 GMT ; RFC 822, updated by RFC 1123
      Sunday, 06-Nov-94 08:49:37 GMT ; RFC 850, obsoleted by RFC 1036
      Sun Nov 6 08:49:37 1994 ; ANSI C's asctime() format

   The first format is preferred as an Internet standard and represents
   a fixed-length subset of that defined by RFC 1123 [8] (an update to
   RFC 822 [9]). The second format is in common use, but is based on the
   obsolete RFC 850 [12] date format and lacks a four-digit year.
   HTTP/1.1 clients and servers that parse the date value MUST accept
   all three formats (for compatibility with HTTP/1.0), though they MUST
   only generate the RFC 1123 format for representing HTTP-date values
   in header fields. See section 19.3 for further information.

The last sentence is of particular importance: HTTP/1.1 servers MUST accept all three formats. The functional tests are feeding in asctime()-formatted date+time values, and Swift MUST accept them. (The RFC mention's C's asctime() format, but Python's is the same AFAIK.)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/57592
Committed: https://git.openstack.org/cgit/openstack/swift/commit/?id=72ade27ea322056b993da8cfd389476461a845af
Submitter: Jenkins
Branch: master

commit 72ade27ea322056b993da8cfd389476461a845af
Author: Kun Huang <email address hidden>
Date: Thu Nov 21 11:14:34 2013 +0800

    test 3 date format in functional tests

    According to HTTP/1.1, servers MUST accept all three formats:

    Sun, 06 Nov 1994 08:49:37 GMT # RFC 822, updated by RFC 1123
    Sunday, 06-Nov-94 08:49:37 GMT # RFC 850, obsoleted by RFC 1036
    Sun Nov 6 08:49:37 1994 # ANSI C's asctime() format

    In functional tests, a date value header has 3 kinds of format will be
    tested.

    Change-Id: I679ed44576208f2a79bffce787cb55bda4b39705
    Closes-Bug: #1253207

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: feature/ec
Review: https://review.openstack.org/66462

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/66462
Committed: https://git.openstack.org/cgit/openstack/swift/commit/?id=3895441afd1f8ca49a09a483f402a961009a8661
Submitter: Jenkins
Branch: feature/ec

commit bad52f11218a11978d1efb0832f164a60a363cc2
Author: Clay Gerrard <email address hidden>
Date: Fri Jan 10 00:31:55 2014 -0800

    Allow programmatic reloading of Swift hash path config

    New util's function validate_hash_conf allows you to programmatically reload
    swift.conf and hash path global vars HASH_PATH_SUFFIX and HASH_PATH_PREFIX
    when they are invalid.

    When you load swift.common.utils before you have a swift.conf there's no good
    way to force a re-read of swift.conf and repopulate the hash path config
    options - short of restarting the process or reloading the module - both of
    which are hard to unittest. This should be no worse in general and in some
    cases easier.

    Change-Id: I1ff22c5647f127f65589762b3026f82c9f9401c1

commit 7b9c283203479cb9916951e1ce1f466f197dea36
Author: Samuel Merritt <email address hidden>
Date: Fri Jan 10 12:57:53 2014 -0800

    Add missing license header to test file

    All the other tests have license headers, so this one should too.

    I picked 2013 for the copyright year because that's when "git log"
    says it was first and last touched.

    Change-Id: Idd41a179322a3383f6992e72d8ba3ecaabd05c47

commit 47fcc5fca2c5020b69f3c2c7f0a8032f6c77354a
Author: Christian Schwede <email address hidden>
Date: Fri Jan 10 07:14:43 2014 +0000

    Update account quota doc

    A note was added stating that the same limitations apply to
    account quotas as for container quotas. An example on uploads
    without a content-length headers was added.

    Related-Bug: 1267659
    Change-Id: Ic29b527cb71bf5903c2823844a1cf685ab6813dd

commit 6426f762d0d87063f9813630c620d880a4191046
Author: Peter Portante <email address hidden>
Date: Mon Dec 9 20:52:58 2013 -0500

    Raise diskfile.py module coverage to > 98%

    We attempt to get the code coverage (with branch coverage) to 100%,
    but fall short because due to interactions between coverage.py and
    CPython's peephole optimizer. See:

        https://bitbucket.org/ned/coveragepy/issue/198/continue-marked-as-not-covered

    In the main diskfile module, we remove the check for a valid
    "self._tmppath" since it is only one of a number of fields that could
    be verified and it was not worth trying to get coverage for it. We
    also remove the try / except around the close() method call in the
    DiskFileReader's app_iter_ranges() method since it will never be
    called in a context that will raise a quarantine exception (by
    definition ranges can't generate a quarantine event).

    We also:

    * fix where quarantine messages are checked to ensure the
      generator is actually executed before the check
    * in new and modified tests:
      * use assertTrue in place of assert_
      * use assertEqual in place of assertEquals
    * fix references to the reserved word "object"

    Change-Id: I6379be04adfc5012cb0b91748fb3ba3f11200b48

commit 5196eae...