Cliffhanger should gracefully hide fields which do not have data
Bug #1253039 reported by
Nekhelesh Ramananthan
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Flashback |
Fix Released
|
High
|
Arash Badie Modiri |
Bug Description
Currently it seems that when the API does not a return a particular field, the UI sometimes displays an invalid string which is not pretty. We have to lose at these cases.
Steps to reproduce this:
1. Go to Movies Tab
2. Search for the movie "The snow queen"
3. Press the first result
4. In the console, you will notice errors such as "Unable to assign void* to QString".
1. Go to Tv Tab
2. In the Popular carousel, look the tv show "Doctor Who" and click it.
3. In the Tv details page, you will notice the minutes appearing as "undefined minutes", seasons "Qvariant(void*) Seasons" etc etc.
All these should gracefully fall back properly so that the user does not notice this.
Related branches
lp:~arashbm/cliffhanger/empty-fields
- Nekhelesh Ramananthan: Approve
-
Diff: 409 lines (+71/-47)12 files modifiedmodels/Movie.qml (+10/-10)
models/Person.qml (+5/-5)
models/PersonCast.qml (+4/-4)
models/PersonCrew.qml (+5/-4)
models/Season.qml (+5/-5)
models/Show.qml (+6/-7)
models/ShowSeasons.qml (+2/-1)
ui/MoviePage.qml (+9/-2)
ui/PersonPage.qml (+5/-2)
ui/SeasonPage.qml (+4/-1)
ui/TvPage.qml (+14/-4)
ui/TvSeasons.qml (+2/-2)
Changed in cliffhanger: | |
status: | In Progress → Fix Committed |
Changed in cliffhanger: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Hey arash, I assigned this bug to you since you are more familiar with the json functions which requires a little bit more tweaking to address this bug.