GlusterFS: allow snapshot_delete when snapshot info does not exist

Bug #1252864 reported by Eric Harney
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Medium
Eric Harney
Havana
Fix Released
Medium
Eric Harney

Bug Description

The snapshot_delete operation will fail if the backing file for the snapshot does not exist. This happens in legitimate cases such as when snapshot_create fails due to permissions problems.

The driver should allow the manager to delete the snapshot in this case where this is no action required for the driver to delete anything.

Eric Harney (eharney)
Changed in cinder:
assignee: nobody → Eric Harney (eharney)
importance: Undecided → Medium
Eric Harney (eharney)
summary: - GlusterFS: allow snapshot_delete when backing file does not exist
+ GlusterFS: allow snapshot_delete when snapshot info does not exist
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/57335

Changed in cinder:
status: New → In Progress
tags: added: drivers glusterfs
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/57335
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=d8a11168c908fe6c6a07fbb30a5bc88a6df6e939
Submitter: Jenkins
Branch: master

commit d8a11168c908fe6c6a07fbb30a5bc88a6df6e939
Author: Eric Harney <email address hidden>
Date: Tue Nov 19 16:25:47 2013 -0500

    GlusterFS: Complete snapshot_delete when info doesn't exist

    The snapshot_delete operation will fail if the snapshot info file
    doesn't contain a record for the snapshot, or does not exist.
    This happens in cases such as when snapshot_create fails to commit
    anything to disk.

    The driver should allow the manager to delete the snapshot
    in this case, as there is no action required for the driver
    to delete anything.

    Closes-Bug: #1252864

    Change-Id: I8686a1be09dbb7984072538bff6c026bb84eeb52

Changed in cinder:
status: In Progress → Fix Committed
Eric Harney (eharney)
tags: added: havana-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (stable/havana)

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/64949

Thierry Carrez (ttx)
Changed in cinder:
milestone: none → icehouse-2
status: Fix Committed → Fix Released
Alan Pevec (apevec)
tags: removed: havana-backport-potential
Thierry Carrez (ttx)
Changed in cinder:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.