destroy_metadata_proxy not called from _destroy_router_namespaces

Bug #1252856 reported by Carl Baldwin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
neutron
Fix Released
Undecided
Carl Baldwin
Havana
Fix Released
Undecided
Unassigned

Bug Description

In preparing the patch for bug 1250596 I found that _destroy_router_namespaces does not properly destroy the metadata proxy.

It may be that it was not called because _destroy_router_namespaces requires a router_info object that is not available in this context. Maru suggested refactoring _destroy_metadata_proxy and _spawn_metadata_proxy to enable this.

Changed in neutron:
assignee: nobody → Carl Baldwin (carl-baldwin)
summary: - _spawn/destroy_metadata_proxy cannot be called from contexts where full
- router_info is not available
+ destroy_metadata_proxy not called from _destroy_router_namespaces
Changed in neutron:
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (master)

Reviewed: https://review.openstack.org/57293
Committed: http://github.com/openstack/neutron/commit/07d597079781967f5a149f1812ddca3897fa49d9
Submitter: Jenkins
Branch: master

commit 07d597079781967f5a149f1812ddca3897fa49d9
Author: Carl Baldwin <email address hidden>
Date: Tue Nov 19 17:47:43 2013 +0000

    Call _destroy_metadata_proxy from _destroy_router_namespaces

    Refactor _spawn/destroy_metadata_proxy so that it can be called
    with only the namespace and the router_id.

    Change-Id: Id1c33b22c7c3bd35c54a7c9ad419831bfed8746b
    Closes-Bug: #1252856

Changed in neutron:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in neutron:
milestone: none → icehouse-1
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to neutron (stable/havana)

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/84418

Thierry Carrez (ttx)
Changed in neutron:
milestone: icehouse-1 → 2014.1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to neutron (stable/havana)

Reviewed: https://review.openstack.org/84418
Committed: https://git.openstack.org/cgit/openstack/neutron/commit/?id=6cc649a8fcc008a392f046eb3d8029a0658ee1e0
Submitter: Jenkins
Branch: stable/havana

commit 6cc649a8fcc008a392f046eb3d8029a0658ee1e0
Author: Carl Baldwin <email address hidden>
Date: Tue Nov 19 17:47:43 2013 +0000

    Call _destroy_metadata_proxy from _destroy_router_namespaces

    Refactor _spawn/destroy_metadata_proxy so that it can be called
    with only the namespace and the router_id.

    Change-Id: Id1c33b22c7c3bd35c54a7c9ad419831bfed8746b
    Closes-Bug: #1252856
    (cherry picked from commit 07d597079781967f5a149f1812ddca3897fa49d9)
    Related-Bug: #1175695

tags: added: in-stable-havana
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.