[nailgun] RPC reciever calculates wrong result for check_dhcp task

[Andrey Danin]

ISO 3.2

here are a logs:
2013-10-23 21:14:19 INFO (receiver) RPC method check_dhcp_resp received: {"status": "ready", "task_uuid": "b994c28f-e192-4957-8658-bd82d5c25a4a", "nodes": [{"status": "ready", "data": [{"server_id": "10.20.0.2", "iface": "eth0", "yiaddr": "10.20.0.130", "mac": "00:25:90:10:0e:ce", "server_ip": "10.20.0.2", "dport": 67, "message": "offer", "gateway": "0.0.0.0"}], "uid": "2"}, {"status": "ready", "data": [{"server_id": "10.20.0.2", "iface": "eth5", "yiaddr": "10.20.0.155", "mac": "00:25:90:10:0e:ce", "server_ip": "10.20.0.2", "dport": 67, "message": "offer", "gateway": "0.0.0.0"}, {"server_id": "10.20.0.2", "iface": "eth0", "yiaddr": "10.20.0.179", "mac": "00:25:90:10:0e:ce", "server_ip": "10.20.0.2", "dport": 67, "message": "offer", "gateway": "0.0.0.0"}], "uid": "9"}, {"status": "ready", "data": [{"server_id": "10.20.0.2", "iface": "eth5", "yiaddr": "10.20.0.167", "mac": "00:25:90:10:0e:ce", "server_ip": "10.20.0.2", "dport": 67, "message": "offer", "gateway": "0.0.0.0"}, {"server_id": "10.20.0.2", "iface": "eth0", "yiaddr": "10.20.0.176", "mac": "00:25:90:10:0e:ce", "server_ip": "10.20.0.2", "dport": 67, "message": "offer", "gateway": "0.0.0.0"}], "uid": "8"}]}
2013-10-23 21:14:19 DEBUG (receiver) Mac addr on master node ['00:00:00:00:00:00', '00:25:90:10:0e:ce', '00:25:90:10:0e:cf']
2013-10-23 21:14:19 DEBUG (receiver) Check dhcp message None
2013-10-23 21:14:19 DEBUG (helpers) Updating task: b994c28f-e192-4957-8658-bd82d5c25a4a
2013-10-23 21:14:19 INFO (helpers) Task b994c28f-e192-4957-8658-bd82d5c25a4a (check_dhcp) status is set to ready
2013-10-23 21:14:19 INFO (helpers) Task b994c28f-e192-4957-8658-bd82d5c25a4a (check_dhcp) result is set to defaultdict(<type 'list'>, {})
2013-10-23 21:14:19 DEBUG (helpers) Updating cluster status: cluster_id: 4 status: ready
2013-10-23 21:14:19 DEBUG (helpers) Updating parent task: e34b5905-1665-4cef-bf75-0e4a47bc5778.

Suspicious message is: result is set to defaultdict(<type 'list'>, {})

I think the result should have some other value.

[Aleksey Kasatkin (alekseyk-ru)]

This message means that no problem was found during the test.
Non-empty dict is returned otherwise.

[Aleksey Kasatkin (alekseyk-ru)]

This can be changed to None or {} instead of defaultdict(<type 'list'>, {}).