Port node_id and Node chassis_id in the API are misleading names and should be renamed

Bug #1252213 reported by Lucas Alvares Gomes
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Medium
Lucas Alvares Gomes

Bug Description

The Ports nodes_id and Node chassis_id attributes in the API only accepts UUIDs, such names are misleading the value of those fields and for that should be renamed to node_uuid and chassis_uuid instead.

Changed in ironic:
assignee: nobody → Lucas Alvares Gomes (lucasagomes)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/56682
Committed: http://github.com/openstack/ironic/commit/282ec175473c46104d4ee951dd5026acb9643fcd
Submitter: Jenkins
Branch: master

commit 282ec175473c46104d4ee951dd5026acb9643fcd
Author: Lucas Alvares Gomes <email address hidden>
Date: Fri Nov 15 18:39:49 2013 +0000

    API ports update for WSME 0.5b6 compliance

    This makes use of the mandatory option of WSME, to remove some of the
    custom validation code. The patch also includes a new attribute on
    Ports API object called node_uuid to store the UUID of the node that
    Port belongs to, once this field is set it magically converts the UUID
    to the numeric ID of the node and sets the node_id attribute to be
    used internally.

    Change-Id: I973987de48fa008f5752861a2acfaf819f80e2ad
    Partial-Bug: #1252213

aeva black (tenbrae)
Changed in ironic:
importance: Undecided → Medium
Changed in ironic:
milestone: none → icehouse-2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/57495
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=812ab0d265c63b85a4747ec76a094af09f1a82bf
Submitter: Jenkins
Branch: master

commit 812ab0d265c63b85a4747ec76a094af09f1a82bf
Author: Lucas Alvares Gomes <email address hidden>
Date: Tue Nov 19 16:13:53 2013 +0000

    Reworks Node validations

    This makes use of the mandatory option and complex types of WSME to
    remove some of the custom validation code. The patch also includes a
    new attribute on Nodes API object called chassis_uuid to store the UUID
    of the chassis that Node belongs to, once this field is set it magically
    converts the UUID to the numeric ID of the chassis and sets the chassis_id
    attribute to be used internally.

    Change-Id: Ie51761a3b9a018d101a6335ea7bafb09393816d4
    Closes-Bug: #1252213
    Partial-Bug: #1223847

Changed in ironic:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in ironic:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in ironic:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.