fwaas service can't run in operation system without namespace feature

[Hua Zhang]

Fwaas service can't run in operation system without namespace feature although use_namespaces equals False

$ grep -r "^use_namespaces =" /etc/neutron/l3_agent.ini
use_namespaces = False

Bellow is error log:

2013-11-18 14:52:09.782 INFO neutron.agent.l3_agent [-] L3 agent started
2013-11-18 14:52:14.553 ERROR neutron.services.firewall.agents.l3reference.firewall_l3_agent [-] FWaaS RPC info call failed for '770d54af-2bb6-4233-8a39-1d5ad36fea59'.
2013-11-18 14:52:14.553 TRACE neutron.services.firewall.agents.l3reference.firewall_l3_agent Traceback (most recent call last):
2013-11-18 14:52:14.553 TRACE neutron.services.firewall.agents.l3reference.firewall_l3_agent File "/bak/openstack/neutron/neutron/services/firewall/agents/l3reference/firewall_l3_agent.py", line 213, in process_router_add
2013-11-18 14:52:14.553 TRACE neutron.services.firewall.agents.l3reference.firewall_l3_agent self._process_router_add(ri)
2013-11-18 14:52:14.553 TRACE neutron.services.firewall.agents.l3reference.firewall_l3_agent File "/bak/openstack/neutron/neutron/services/firewall/agents/l3reference/firewall_l3_agent.py", line 193, in _process_router_add
2013-11-18 14:52:14.553 TRACE neutron.services.firewall.agents.l3reference.firewall_l3_agent ri.router['tenant_id'])
2013-11-18 14:52:14.553 TRACE neutron.services.firewall.agents.l3reference.firewall_l3_agent File "/bak/openstack/neutron/neutron/services/firewall/agents/l3reference/firewall_l3_agent.py", line 92, in _get_router_info_list_for_tenant
2013-11-18 14:52:14.553 TRACE neutron.services.firewall.agents.l3reference.firewall_l3_agent local_ns_list = root_ip.get_namespaces(self.root_helper)
2013-11-18 14:52:14.553 TRACE neutron.services.firewall.agents.l3reference.firewall_l3_agent File "/bak/openstack/neutron/neutron/agent/linux/ip_lib.py", line 174, in get_namespaces
2013-11-18 14:52:14.553 TRACE neutron.services.firewall.agents.l3reference.firewall_l3_agent output = cls._execute('', 'netns', ('list',), root_helper=root_helper)
2013-11-18 14:52:14.553 TRACE neutron.services.firewall.agents.l3reference.firewall_l3_agent File "/bak/openstack/neutron/neutron/agent/linux/ip_lib.py", line 76, in _execute
2013-11-18 14:52:14.553 TRACE neutron.services.firewall.agents.l3reference.firewall_l3_agent root_helper=root_helper)
2013-11-18 14:52:14.553 TRACE neutron.services.firewall.agents.l3reference.firewall_l3_agent File "/bak/openstack/neutron/neutron/agent/linux/utils.py", line 75, in execute
2013-11-18 14:52:14.553 TRACE neutron.services.firewall.agents.l3reference.firewall_l3_agent raise RuntimeError(m)
2013-11-18 14:52:14.553 TRACE neutron.services.firewall.agents.l3reference.firewall_l3_agent RuntimeError:
2013-11-18 14:52:14.553 TRACE neutron.services.firewall.agents.l3reference.firewall_l3_agent Command: ['sudo', '/usr/bin/neutron-rootwrap', '/etc/neutron/rootwrap.conf', 'ip', 'netns', 'list']
2013-11-18 14:52:14.553 TRACE neutron.services.firewall.agents.l3reference.firewall_l3_agent Exit code: 255
2013-11-18 14:52:14.553 TRACE neutron.services.firewall.agents.l3reference.firewall_l3_agent Stdout: ''
2013-11-18 14:52:14.553 TRACE neutron.services.firewall.agents.l3reference.firewall_l3_agent Stderr: 'Object "netns" is unknown, try "ip help".\n'
2013-11-18 14:52:14.553 TRACE neutron.services.firewall.agents.l3reference.firewall_l3_agent

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/56893

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/56893
Committed: http://github.com/openstack/neutron/commit/17b8cedeaa291f973e8311865b6560dc4806888d
Submitter: Jenkins
Branch: master

commit 17b8cedeaa291f973e8311865b6560dc4806888d
Author: zhhuabj <email address hidden>
Date: Mon Nov 18 18:09:54 2013 +0800

    Fwaas can't run in operating system without namespace feature

    Adding the check before generating the local_ns_list
    to fix the issue.

    Change-Id: If8edb5c0bb0fc0fd9aaf48a3441287f99bcdcf13
    Closes-Bug: #1252201