Stack pagination supports sorting by any column in the stack table

Bug #1252116 reported by Steve Baker
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
High
Richard Lee

Bug Description

The allowed sort_keys should really be limited to a known list of indexed columns. Initially this list should probably be:
stack.created_at
stack.updated_at
stack.name
stack.status

This might be best enforced in api.stack_get_all_by_tenant

Changed in heat:
assignee: nobody → Richard Lee (rblee88)
Revision history for this message
Steve Baker (steve-stevebaker) wrote :

See bug #1252115 for the task to created the indexes for these columns

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/57339

Changed in heat:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/57339
Committed: http://github.com/openstack/heat/commit/7f638afb06d2b85db26cdfd13c20436574dbbb3a
Submitter: Jenkins
Branch: master

commit 7f638afb06d2b85db26cdfd13c20436574dbbb3a
Author: Richard Lee <email address hidden>
Date: Tue Nov 19 16:30:22 2013 -0600

    Restrict sort_keys for stack lists

    We are only allowing users to sort stacks on a subset of columns that
    are known to be indexed. Currently allowed sort columns are:

    created_at
    updated_at
    name
    status

    Change-Id: Ib4f955336edd7d86a1b6bf98e38378b0d495d0dd
    Closes-Bug: 1252116

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.