baremetal deploy helper should abort immediately if target block devices are not available

Bug #1251525 reported by Arata Notsu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
High
Lucas Alvares Gomes
OpenStack Compute (nova)
Fix Released
Medium
Arata Notsu

Bug Description

nova-baremetal-deploy-helper does not stop a deployment even if a target block device or partitions are not available. In such case, the instance will fail to boot but nova will mark the instance as ACTIVE. So the user can know the failure only by the fact that the instance does not become accessible after a long time has passed.

The deployment should be stopped immediately and the instance should be marked as ERROR.

Tags: baremetal
Revision history for this message
aeva black (tenbrae) wrote :

Fix proposed to https://review.openstack.org/#/c/56525/

This also affects Ironic, and the fix should be ported and applied to ironic/drivers/modules/deploy_utils.py

Changed in nova:
status: New → Confirmed
Changed in ironic:
status: New → Confirmed
importance: Undecided → High
Arata Notsu (arata776)
Changed in nova:
assignee: nobody → Arata Notsu (arata776)
status: Confirmed → In Progress
Changed in ironic:
assignee: nobody → Lucas Alvares Gomes (lucasagomes)
aeva black (tenbrae)
Changed in nova:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/59493

Changed in ironic:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/59493
Committed: http://github.com/openstack/ironic/commit/71d3bcd9f928a99e5b16a330a5acef7fc36d6689
Submitter: Jenkins
Branch: master

commit 71d3bcd9f928a99e5b16a330a5acef7fc36d6689
Author: Lucas Alvares Gomes <email address hidden>
Date: Mon Dec 2 17:29:06 2013 +0000

    If no block devices abort deployment

    Based on https://review.openstack.org/#/c/56525

    Make the deployment to abort immediately in case the block devices are
    not available.

    Change-Id: Id1a23578b0e6c7f69bbf6e5a76f3e42f37980ba6
    Partial-Bug: #1251525

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/56525
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=43bc41c31d9c8a52098560e08fc9f6d13c9675b9
Submitter: Jenkins
Branch: master

commit 43bc41c31d9c8a52098560e08fc9f6d13c9675b9
Author: Arata Notsu <email address hidden>
Date: Fri Nov 15 14:16:55 2013 +0900

    baremetal: stop deployment if block devices are not available

    In this case deploy-helper should abort immediately and make sure
    that the instance's status set to ERROR.

    Closes-Bug: 1251525
    Change-Id: Ic09f171edb0fe3a449c7adfe622ab48709c73252

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → icehouse-2
status: Fix Committed → Fix Released
aeva black (tenbrae)
Changed in ironic:
status: In Progress → Fix Released
Thierry Carrez (ttx)
Changed in nova:
milestone: icehouse-2 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.