finish_revert_migration does not include context as parameter
Bug #1251261 reported by
Guangya Liu (Jay Lau)
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
Fix Released
|
Undecided
|
Guangya Liu (Jay Lau) | ||
Havana |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
When finish_
finish_
but finish_
re-generate the context inside finish_
add context as a new parameter for finish_
the functions inside of it can reuse context when needed.
For the function _create_
it set context as an optional parameter, but context isn't really
an optional parameter for this method. We should always pass a
context down because it might be needed somewhere inside
_create_
Changed in nova: | |
assignee: | nobody → Jay Lau (jay-lau-513) |
Changed in nova: | |
status: | New → In Progress |
Changed in nova: | |
milestone: | none → icehouse-1 |
Changed in nova: | |
status: | Fix Committed → Fix Released |
tags: | added: havana-backport-potential |
Changed in nova: | |
milestone: | icehouse-1 → 2014.1 |
To post a comment you must log in.
Reviewed: https:/ /review. openstack. org/54309 github. com/openstack/ nova/commit/ 81fc3967bca0f15 4d72d5de7875b64 6e1b6c47c8
Committed: http://
Submitter: Jenkins
Branch: master
commit 81fc3967bca0f15 4d72d5de7875b64 6e1b6c47c8
Author: Jay Lau <email address hidden>
Date: Fri Nov 22 23:32:38 2013 +0800
Add context as parameter for two libvirt APIs
When finish_ revert_ migration is called, the caller of revert_ migration already includes context as a parameter, revert_ migration did not reuse this parameter and still revert_ migration, we should revert_ migration so that
finish_
but finish_
re-generate the context inside finish_
add context as a new parameter for finish_
the functions inside of it can reuse context when needed.
For the function _create_ domain_ and_network in libvirt/driver.py, domain_ and_network( ).
it set context as an optional parameter, but context isn't really
an optional parameter for this method. We should always pass a
context down because it might be needed somewhere inside
_create_
The patch includes two parts: revert_ migration domain_ and_network
1) Add context as a new parameter for finish_
2) Set context as a required parameter for _create_
Change-Id: I72d131fc8dce90 3400e3080d51ba0 fc0a1320751
Closes-Bug: #1251261