missing instruction of exit ‘Full Screen’ Mode in VNC console

[Roey Dekel]

Description of problem:
===================
While using horizon, after choosing an instance's console, there's an option to "show only console" (which work quite similar to full screen). But there is no button nor shortcut to exit it.

How reproducible:
==============
Steps to Reproduce:
1. Launch instance
2. Enter its vnc console via horizon
3. Select "click here to show only console"
4. Now try to get back

Comments:
=========
The only way to exit it is to use the browser's back button. It can be fixed by adding return button or comment for how to do it (using the back button)

[Facundo Maldonado (facundo-n-maldonado)]

Two possibilities:
1- If we want to add a return button, it should be added in the noVNC code base, as it is not part of the Openstack project.
2- Much simpler, add a message below the one with the link "show only console".

How do you want to proceed?

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/62630

[Roey Dekel (rdekel)]

I think that choosing the first possibility is better for long term (it's more intuitive). But for short term the second possibility will work fine. I don't rule out the possibility to them both.

[Matthias Runge (mrunge)]

Roey, I don't see, how changing in 1 is possible, since it wouldn't be really useful there. I assume, a patch probably wouldn't be accepted upstream;

[Roey Dekel (rdekel)]

In my opinion simple GUI should be our guideline, therefore adding a button couldn't harm and can only help simple end users. It's not a blocker though, because a message will give them solution.

[Roey Dekel (rdekel)]

Furthermore, we already have a button there (Send CtrlAltDel), it only requires to have another one.

[Matthias Runge (mrunge)]

Roey, that does not come from Horizon at all, it's just passed through.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/62630
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=5c83f7fad9058a2c0d8236a671092854a2790cf7
Submitter: Jenkins
Branch: master

commit 5c83f7fad9058a2c0d8236a671092854a2790cf7
Author: Facundo Maldonado <email address hidden>
Date: Fri Dec 13 14:36:56 2013 -0300

    New message added informing how to exit fullscreen mode.

    Fixing this bug in the full screen mode involves patching it
    on noVNC codebase.
    This patch adds a comment for how to exit the full screen
    mode using the browser's back button.

    Change-Id: Ibcf510efadd6a1f29e0b2693ce9e332d54652d62
    Closes-Bug:1251196