test_get_dss_rp in test_vmware_vmdk.py not testing the positive case as intended

Bug #1251126 reported by Vipin Balachandran
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Cinder
Fix Released
Undecided
Vipin Balachandran

Bug Description

The test "test_get_dss_rp" in test_vmware_vmdk.py is not testing the positive case as intended. Rather, it tests the negative case (no datastores) which is already covered by "test_get_dss_rp_without_datastores".

tags: added: vmdk vmware
Changed in cinder:
assignee: nobody → Vipin Balachandran (vbala)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to cinder (master)

Fix proposed to branch: master
Review: https://review.openstack.org/56355

Changed in cinder:
status: New → In Progress
tags: added: havana-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to cinder (master)

Reviewed: https://review.openstack.org/56355
Committed: http://github.com/openstack/cinder/commit/8f8be6815e6a7d26165ee6f185821597e56cb740
Submitter: Jenkins
Branch: master

commit 8f8be6815e6a7d26165ee6f185821597e56cb740
Author: Vipin Balachandran <email address hidden>
Date: Wed Nov 13 22:09:37 2013 +0530

    To fix test_get_dss_rp in test_vmware_vmdk.py

    The test "test_get_dss_rp" in test_vmware_vmdk.py is not testing
    the positive case as intended. Rather, it tests the negative case
    (no datastores) which is already covered by
    "test_get_dss_rp_without_datastores".

    Change-Id: I5b4802e22218217e0338fc721fc0ce1efeaee4f1
    Closes-Bug: #1251126

Changed in cinder:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in cinder:
milestone: none → icehouse-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in cinder:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.