Remove 'file' source type when HORIZON_IMAGES_ALLOW_UPLOAD is False

Bug #1251101 reported by Kieran Spear
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Kieran Spear

Bug Description

settings.HORIZON_IMAGES_ALLOW_UPLOAD is meant to hide everything related to direct file uploads in the CreateImage dialog, but at the moment it's just removing the image_file field and leaving "File" as an option in the Source type dropdown.

Kieran Spear (kspear)
Changed in horizon:
status: New → In Progress
assignee: nobody → Kieran Spear (kspear)
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/56323

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/56323
Committed: http://github.com/openstack/horizon/commit/803d02b39390d2adbfe5fcb46fe54d51344c7fb8
Submitter: Jenkins
Branch: master

commit 803d02b39390d2adbfe5fcb46fe54d51344c7fb8
Author: Kieran Spear <email address hidden>
Date: Thu Nov 14 12:20:44 2013 +1100

    Remove 'file' source type when HORIZON_IMAGES_ALLOW_UPLOAD is False

    settings.HORIZON_IMAGES_ALLOW_UPLOAD is meant to hide everything
    related to direct file uploads in the CreateImage dialog, but at
    the moment it's just removing the image_file field and leaving
    "File" as an option in the Source type dropdown.

    This change removes the 'file' source type when necessary, and
    hides the source type field altogether if there is only one source.

    Change-Id: Idefb225bccb26fc4cf04f78387e205cb2fbacfd9
    Closes-bug: 1251101

Changed in horizon:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in horizon:
milestone: none → icehouse-1
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.