defaulting to pycurl doesn't make sense anymore
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
Medium
|
Jelmer Vernooij |
Bug Description
bzr logged that it couldn't find pycurl, so I installed it. As a result,
ctrl-c stopped working. I asked on #bzr about this, and it turned out
that defaulting to pycurl has become sub-optimal.
<jam-laptop> [pycurl] used to be better (supported connection caching, etc)
<jam-laptop> But we have updated our urllib to support connection caching
<jam-laptop> the only real downside pycurl had was the ^C issue
<jam-laptop> but as you noticed, it is a bit of an issue :)
[...]
<jam-laptop> neaj: urllib support is now probably better than pycurl
<jam-laptop> The only thing pycurl does atm that urllib doesn't is
[...]
<jam-laptop> Though that is a mixed blessing
<jam-laptop> as people often have self-signed certificates
[...]
<jam-laptop> and pycurl will block connecting to them :)
[...]
<jam-laptop> that our urllib support has improved to the point
<jam-laptop> that it is worth not defaulting to pycurl anymore
Related branches
- Vincent Ladeuil: Needs Fixing
- Martin Packman (community): Approve
-
Diff: 441 lines (+293/-18)9 files modifiedbzrlib/config.py (+7/-0)
bzrlib/errors.py (+8/-0)
bzrlib/tests/__init__.py (+1/-0)
bzrlib/tests/test_http.py (+0/-1)
bzrlib/tests/test_https_urllib.py (+109/-0)
bzrlib/transport/__init__.py (+3/-3)
bzrlib/transport/http/_urllib2_wrappers.py (+142/-14)
doc/en/release-notes/bzr-2.5.txt (+6/-0)
doc/en/whats-new/whats-new-in-2.5.txt (+17/-0)
- Vincent Ladeuil: Approve
-
Diff: 37 lines (+8/-3)2 files modifiedbzrlib/transport/__init__.py (+3/-3)
doc/en/release-notes/bzr-2.6.txt (+5/-0)
Changed in bzr: | |
importance: | Undecided → Medium |
status: | New → Confirmed |
Changed in bzr: | |
assignee: | nobody → v-ladeuil |
tags: | added: http pycurl |
Changed in bzr: | |
assignee: | Vincent Ladeuil (vila) → Jelmer Vernooij (jelmer) |
status: | Confirmed → In Progress |
Changed in bzr: | |
milestone: | none → 2.6b1 |
status: | In Progress → Fix Released |
i also installed pycurl because of that log entry. now i occasionally get
bzr: ERROR: Connection error: curl connection error (Could not resolve host: bazaar. launchpad. net (Domain name not found))
errors. disabling pycurl fixes them. so if the certificate validation is pycurls only advantage over urllib, i would +1 the suggestion here.
(bzr 0.90.0, pycurl- ssl-7.16. 4.win32- py2.5)