Not all image custom properties are displayed

Bug #1249543 reported by Ryan Hsu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Medium
Ryan Hsu

Bug Description

Currently, the Image Detail page does not display all custom properties of a given image. The root cause is because the code in the template only shows properties that are in a specific whitelist[1]. This is a problem as some hypervisors make heavy use of custom properties and users often have to resort to programmatic access to retrieve them. For deployments where users do not have access to API or CLI, it would be nice to display the custom properties on the image detail page.

[1] https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/project/images_and_snapshots/templates/images_and_snapshots/images/_detail_overview.html#L54

Ryan Hsu (rhsu)
Changed in horizon:
assignee: nobody → Ryan Hsu (rhsu)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/55715

Changed in horizon:
status: New → In Progress
Revision history for this message
David Lyle (david-lyle) wrote :

I agree that just displaying 3 hard coded values is of limited value.

Revision history for this message
Matthias Runge (mrunge) wrote :

Well, replacing a list of properties by a list of other properties is not optimal: Let's make it configurable in local_settings, add the translation strings there too, and we're set here for the future.

Revision history for this message
Ryan Hsu (rhsu) wrote :

Hi Mathias, I have implemented the local_settings part now :)

Revision history for this message
Ryan Hsu (rhsu) wrote :

Tests have been added!

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/55715
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=def80bef83c579114e16a0eae139ce7c1a28cecb
Submitter: Jenkins
Branch: master

commit def80bef83c579114e16a0eae139ce7c1a28cecb
Author: Ryan Hsu <email address hidden>
Date: Fri Nov 8 23:01:03 2013 -0800

    Show all custom properties on image detail page

    Display all custom properties of a given image on the Image Detail
    page. Titles for the custom properties can optionally be displayed
    if they are defined in IMAGE_CUSTOM_PROPERTY_TITLES in local
    settings.

    Change-Id: I7366ec06bf7d77810d7d8fd343390bc1a5eb0674
    Closes-Bug: #1249543

Changed in horizon:
status: In Progress → Fix Committed
Changed in horizon:
milestone: none → icehouse-2
importance: Undecided → Medium
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: icehouse-2 → 2014.1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (stable/havana)

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/92925

Ryan Hsu (rhsu)
tags: added: havana-backport-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on horizon (stable/havana)

Change abandoned by Alan Pevec (<email address hidden>) on branch: stable/havana
Review: https://review.openstack.org/92925
Reason: Final Havana release 2013.2.4 has been cut and stable/havana is going to be removed in a week.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.