auth_encryption_key parameter is overwritten at every puppet run

[Simon Pasquier]

Every time, the heat::engine manifest is executed, it generates a new value for auth_encryption_key. This is highly undesirable because it breaks requests to the CFN API (at least).

The problem is that heat_config [0] is always executed so the 'onlyif' condition of heat-encryption-key-replacement [1] is always true.

[0] https://github.com/stackforge/puppet-heat/blob/master/manifests/engine.pp#L48
[1] https://github.com/stackforge/puppet-heat/blob/master/manifests/engine.pp#L41

[Benedikt Trefzer (benedikt-trefzer)]

I can confirm this behaviour.

the 'onlyif' statement is correct. but for each puppetrun the key is overwritten with the pattern:

notice: /Stage[main]/Heat::Engine/Heat_config[DEFAULT/auth_encryption_key]/value: value changed '27341f3aa61cdb4ec5d0ae62e7803838' to '%ENCRYPTION_KEY%'
info: /Stage[main]/Heat::Engine/Heat_config[DEFAULT/auth_encryption_key]: Scheduling refresh of Service[heat-engine]
notice: /Stage[main]/Heat::Engine/Exec[heat-encryption-key-replacement]/returns: executed successfully

I suggest, to remove the automatic generation of auth_encryption_key, and use a parameter.
This also makes it possible to setup more than one heat-engine, or to move ist to another node etc.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/57881

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/61106

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/61106
Committed: https://git.openstack.org/cgit/stackforge/puppet-heat/commit/?id=9a885b068b90e1e9d89a6ceee7b857b06fc090ea
Submitter: Jenkins
Branch: master

commit 9a885b068b90e1e9d89a6ceee7b857b06fc090ea
Author: François Charlier <email address hidden>
Date: Tue Dec 10 12:51:10 2013 +0100

    make auth_encryption_key a parameter

    Also add tests for heat::engine

    Change-Id: Ic84344060eaad006026fb6b66d569efa3d2592e3
    Closes-Bug: #1249280

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/65077

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/65077
Committed: https://git.openstack.org/cgit/stackforge/puppet-heat/commit/?id=ea456832f3c36604fbc126b86711006e53a61a8c
Submitter: Jenkins
Branch: stable/havana

commit ea456832f3c36604fbc126b86711006e53a61a8c
Author: François Charlier <email address hidden>
Date: Tue Dec 10 12:51:10 2013 +0100

    make auth_encryption_key a parameter

    Also add tests for heat::engine

    Change-Id: Ic84344060eaad006026fb6b66d569efa3d2592e3
    Closes-Bug: #1249280
    (cherry picked from commit 9a885b068b90e1e9d89a6ceee7b857b06fc090ea)