select disk prompt accepts empty input

[Igor Shishkin]

When we're trying to install master node on machine with two or more disks anaconda runs custom where-to-install-promt(described in ks.template) which accepts the empty input instead of disk name. This adduces to anaconda's fail.

Desired behaviour is to ask forever until user doesn't enter valid block device name.

[Andrey Danin (gcon-monolake)]

https://github.com/stackforge/fuel-main/blob/cb36a45a6148f742665f4b0b426d69350a5f2243/iso/ks.template#L38
The infinite loop you are talking about is already exist but perhaps it's broken. We need just to fix it.

[Matthew Mosesohn (raytrac3r)]

ISO 137 has the patch. Still waiting on QA resource to verify this.

[Matthew Mosesohn (raytrac3r)]

Steps to reproduce original bug:
1 - Install Fuel from ISO on a system with 2 or more disks
2 - Receive prompt "Which of the detected hard drives do you want to be used as installation target?"
3 - Type Enter (no input) or enter an invalid disk ID

Previous results:
Input would be accepted and install would fail later

With patch ( https://review.openstack.org/#/c/74032/ ):
Outputs "Invalid choice. Press Enter to continue." (and prompts user to hit Enter)
Program repeats previous prompt infinitely until a valid choice is entered

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/74032
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=b76448a98badd804dd0095685b2b3851d8a405ef
Submitter: Jenkins
Branch: master

commit b76448a98badd804dd0095685b2b3851d8a405ef
Author: Matthew Mosesohn <email address hidden>
Date: Mon Feb 17 14:24:31 2014 +0400

    Error handling for disk prompt in Fuel

    Change-Id: Id16eef106844d4dfbc30cc459dfe4314b78675ad
    Closes-Bug: #1248903

[Andrey Sledzinskiy (asledzinskiy)]

verified on fuel 4.1 iso#248