disable_test_log(enable_test_log(to_file)) should be a noop, but isn't

[Jonathan Lange]

   opaque_handle = enable_test_log(to_file)
   disable_test_log(opaque_handle)

isn't the no-op it should be, since it ends up effectively calling enable_default_logging() instead of leaving the logging system uninitialised.

enable/disable_test_log should *just* restore the state of the trace module, and not call disable/enable_default_logging.

[Jonathan Lange (jml)]

This bug was discovered while investigating bug 124153.

[John A Meinel (jameinel)]

Basically, enable_test_log() sets log to a specific file (for the test suite), but disable_test_log pretty much universally calls 'enable_default_logging'. Which is okay for bzr itself, but other people calling our test suite will not use the same logging functionality.

(Most notably Launchpad :)

So there should be a better way such that enable/disable restores the original state. (Possibly by just updating the returned tuple to make it easier to restore the old settings)

[Martin Pool (mbp)]

working on this with jml

[Martin Pool (mbp)]

Fixed in my branch, I think:

[1] mbp@lithe% python ../124153-repro.py
failed to open trace file: [Errno 2] No such file or directory: '/tmp/testbzr-BH_NjX.tmp/tmpzjj-Jt/home/.bzr.log'
[1] mbp@lithe% pythonpath=. python ../124153-repro.py