Wrong comparisons with "in" operator

[Alvaro Lopez]

In the code there are several comparisons using the "in" operator to check if a value occurs in a tuple with only one element, like:

    if a in ("foo"):
        do_something()

This comparison is wrong, since that is not a tuple with one element [1], therefore if the variable "a" had a value of "f" it will match.

[1] http://docs.python.org/2/tutorial/datastructures.html#tuples-and-sequences

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/55362

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/55362
Committed: http://github.com/openstack/nova/commit/47c95694e93b361e3b0738afac8e724557a36c8a
Submitter: Jenkins
Branch: master

commit 47c95694e93b361e3b0738afac8e724557a36c8a
Author: Alvaro Lopez Garcia <email address hidden>
Date: Wed Nov 6 09:29:05 2013 +0100

    Fix "in" comparisons with one element tuples

    A single value enclosed in parentheses is not a tuple (it needs a comma
    after the element) therefore the comparisons like 'if foo in ("bar")'
    are wrong.

    Closes-Bug: #1248443
    Change-Id: I29a2227c9d83efc17ecfacc86d507d75edd4eaca