Inconsistent dnspython imports break zone import/export in production

Bug #1248247 reported by Artom Lifshitz
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Designate
Fix Released
Medium
Artom Lifshitz
Icehouse
Fix Released
Medium
Artom Lifshitz

Bug Description

The zones.py controller imports dnspython with 'import dns', then uses it as 'dns.zone.blah'. This works in unit tests, but does not work in production deployments.

The cause looks to be as follows.

It seems that because the test_zones.py unit tests import dnspython with 'from dns import zone as dnszone', dns.zone becomes usable, whereas it shouldn't be if simply 'import dns' was used.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to designate (master)

Fix proposed to branch: master
Review: https://review.openstack.org/55305

Changed in designate:
assignee: nobody → Artom Lifshitz (artom-lifshitz)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to designate (master)

Reviewed: https://review.openstack.org/55305
Committed: http://github.com/stackforge/designate/commit/b8df7bd0eee87b272174e8d2d9c36cc06bf3e6af
Submitter: Jenkins
Branch: master

commit b8df7bd0eee87b272174e8d2d9c36cc06bf3e6af
Author: Artom Lifshitz <email address hidden>
Date: Tue Nov 5 11:42:00 2013 -0500

    Fix inconsistent dnspython imports bug

    Change-Id: Iec3862805778a7c295c9d23385270c54d71a1452
    Closes-bug: 1248247

Changed in designate:
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Related blueprints

Remote bug watches

Bug watches keep track of this bug in other bug trackers.