The Loadbalancer agent's binary name as appears in the agents db table is wrong

[Rami Vaknin]

Version
=======
Havana on rhel
openstack-neutron-2013.2-3.el6ost

Description
===========
The Loadbalancer agent's binary in the "agents" database table differs from the real binary name and service name.

# mysql -u root ovs_neutron
mysql> select * from agents where agent_type like "Loadbalancer agent";
+--------------------------------------+--------------------+----------------------------+-----------------------------+-------------------------------+----------------+---------------------+---------------------+---------------------+-------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| id | agent_type | binary | topic | host | admin_state_up | created_at | started_at | heartbeat_timestamp | description | configurations |
+--------------------------------------+--------------------+----------------------------+-----------------------------+-------------------------------+----------------+---------------------+---------------------+---------------------+-------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
| 7f0b2ac3-5478-4a80-9c09-5856956d0160 | Loadbalancer agent | neutron-loadbalancer-agent | lbaas_process_on_host_agent | shtutgmuralegamrey.redhat.com | 1 | 2013-11-05 13:02:45 | 2013-11-05 13:02:45 | 2013-11-05 14:54:09 | NULL | {"device_driver": "neutron.services.loadbalancer.drivers.haproxy.namespace_driver.HaproxyNSDriver", "interface_driver": "neutron.agent.linux.interface.OVSInterfaceDriver", "devices": 1} |
+--------------------------------------+--------------------+----------------------------+-----------------------------+-------------------------------+----------------+---------------------+---------------------+---------------------+-------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
1 row in set (0.00 sec)

The binary here is "neutron-loadbalancer-agent" while the real binary should probably be "neutron-lbaas-agent".

# rpm -ql openstack-neutron | grep neutron-loadbalancer-agent
<empty output>
# rpm -ql openstack-neutron | grep neutron-lbaas-agent
/etc/rc.d/init.d/neutron-lbaas-agent
/usr/bin/neutron-lbaas-agent
/usr/share/neutron/neutron-lbaas-agent.upstart

# service neutron-lbaas-agent status
neutron-lbaas-agent (pid 2321) is running...

# service neutron-loadbalancer-agent status
neutron-loadbalancer-agent: unrecognized service

# ps -elf | grep neutron-loadbalancer-agent | grep -v grep
<empty output>

# ps -elf | grep neutron-lbaas-agent | grep -v grep
0 S neutron 2321 1 0 80 0 - 70231 ep_pol 15:02 ? 00:01:10 /usr/bin/python /usr/bin/neutron-lbaas-agent --log-file /var/log/neutron/lbaas-agent.log --config-file /usr/share/neutron/neutron-dist.conf --config-file /etc/neutron/neutron.conf --config-file /etc/neutron/lbaas_agent.ini

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/55377

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/55377
Committed: http://github.com/openstack/neutron/commit/0da18edec2ca213a9d87778a4679afb891d58a28
Submitter: Jenkins
Branch: master

commit 0da18edec2ca213a9d87778a4679afb891d58a28
Author: Oleg Bondarev <email address hidden>
Date: Wed Nov 6 13:24:43 2013 +0400

    LBaaS: fix reported binary name of a loadbalancer agent

    Loadbalancer agent's actual binary name differs from what it reports
    to Neutron server, so need to fix:
    neutron-loadbalancer-agent -> neutron-lbaas-agent

    Closes-Bug: #1248222
    Change-Id: Ic4e05d0258ba8eb48b96c60d69c1dbf9f27731f6