def Val gives seg fault

[Jon Hill]

Calling your python function Val rather than val causes a seg fault.

We should at least have a nice error!

[Jon Hill (jon-hill)]

This is the offending line of code (line 79 embed_python.c)
  // Extract the function from the code.
  pFunc=PyDict_GetItemString(pLocals, "val");

If there is no val item, then pFunc is NULL, so when you call it, you get a seg fault...

Edit to:
  // Extract the function from the code.
  pFunc=PyDict_GetItemString(pLocals, "val");
  if (pFunc == NULL) {
      printf("Couldn't find a 'val' function in your Python code.\n");
      *stat=1;
      return;
  }

?

[Jon Hill (jon-hill)]

Ah, that seems to work nicely. Gives us this:

Couldn't find a 'val' function in your Python code.
 Python error while setting field: Temperature
 Python string was:
 def Val(X,t):
  depth=1000
  dT=10
  return (X[1]+depth)/depth*dT
*** ERROR ***
Error message: Dying

Are people happy for this to be pushed straight into trunk?

[Christian Jacobs (ctjacobs)]

Looks good to me. I'm happy for this to be shipped straight to the trunk.