cells: instance_create fails when syncing instances

[Chris Behrens]

2013-10-31 19:03:27.331 11138 ERROR nova.cells.messaging [req-4a1197c5-93b9-4237-aac3-5e4374a7cd39 359445 831861] Error processing message locally: instance_create() got an unexpected keyword argument 'legacy'

This issue snuck in when adding cinder support for cells. An extra kwarg was added when calling instance_create, although one does not exist. (I believe this was a bad rebase at the time)

Note: This is not a serious issue. The cells healing code only tries to instance_create at the API level when trying to update an instance that we find doesn't exist for some reason. It would be extremely rare that the instance wouldn't already exist in the API cell, because someone would have had to delete the DB record manually... or... someone directed a build directly to the child cell without talking to the API cell.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/55170

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/55170
Committed: http://github.com/openstack/nova/commit/a175697798cc2c0788d69f1a6e8b3ffd1be9ed11
Submitter: Jenkins
Branch: master

commit a175697798cc2c0788d69f1a6e8b3ffd1be9ed11
Author: Chris Behrens <email address hidden>
Date: Mon Nov 4 18:34:24 2013 +0000

    Fix cells instance_create extra kwarg

    When the API cell receives a message to update an instance, it'll try to
    create it if it doesn't already exist in order to sync up. However,
    it's calling db.instance_create with an extra kwarg that doesn't exist
    and failing. This patch removes the extra kwarg.

    The bug was introduced in this change id:

    Ife5be9922db0742c8ee4f970517396be86597cce

    Change-Id: I69bcb3dda2cbb566b0d69c5eac005703654ea811
    Closes-bug: 1247919