VMware: rescue with IDE disks fails

[Gary Kotton]

IDE disks are not hot addable. They will cannot be added when a VM is running.

[Gary Kotton (garyk)]

https://review.openstack.org/55070

[ChangBo Guo(gcb) (glongwave)]

This is a traceback:
2013-11-18 22:00:16.637 16297 DEBUG nova.virt.vmwareapi.volumeops [req-6f54a00e-c51b-47ec-92ae-6ffb4cf978bd aadbeb6588a54753a2e70db4719eee57 4e8da11ef9634e368ec44ce24df59b5f]
NV-779F5E4 Reconfiguring VM instance instance-0000000d-rescue to attach disk [datastore_v7k] a52a12f7-190d-450c-9c1d-0b4aab066006/a52a12f7-190d-450c-9c1d-0b4aab066006.vmdk or
device None with type preallocated attach_disk_to_vm /usr/lib/python2.6/site-packages/nova/virt/vmwareapi/volumeops.py:66
2013-11-18 22:00:17.158 16297 WARNING nova.virt.vmwareapi.driver [-] NV-EF000C4 Task [ReconfigVM_Task] (returnval){
   value = "task-1115"
   _type = "Task"
 } status: error The attempted operation cannot be performed in the current state (Powered on).
2013-11-18 22:00:17.159 16297 ERROR nova.compute.manager [req-6f54a00e-c51b-47ec-92ae-6ffb4cf978bd aadbeb6588a54753a2e70db4719eee57 4e8da11ef9634e368ec44ce24df59b5f] [instance: a52a12f7-190d-450c-9c1d-0b4aab066006] Error trying to Rescue Instance
2013-11-18 22:00:17.159 16297 TRACE nova.compute.manager [instance: a52a12f7-190d-450c-9c1d-0b4aab066006] Traceback (most recent call last):
2013-11-18 22:00:17.159 16297 TRACE nova.compute.manager [instance: a52a12f7-190d-450c-9c1d-0b4aab066006] File "/usr/lib/python2.6/site-packages/nova/compute/manager.py", line 2575, in rescue_instance
2013-11-18 22:00:17.159 16297 TRACE nova.compute.manager [instance: a52a12f7-190d-450c-9c1d-0b4aab066006] rescue_image_meta, admin_password)
2013-11-18 22:00:17.159 16297 TRACE nova.compute.manager [instance: a52a12f7-190d-450c-9c1d-0b4aab066006] File "/usr/lib/python2.6/site-packages/nova/virt/vmwareapi/driver.py", line 687, in rescue
2013-11-18 22:00:17.159 16297 TRACE nova.compute.manager [instance: a52a12f7-190d-450c-9c1d-0b4aab066006] _vmops.rescue(context, instance, network_info, image_meta)
2013-11-18 22:00:17.159 16297 TRACE nova.compute.manager [instance: a52a12f7-190d-450c-9c1d-0b4aab066006] File "/usr/lib/python2.6/site-packages/nova/virt/vmwareapi/vmops.py", line 1044, in rescue
2013-11-18 22:00:17.159 16297 TRACE nova.compute.manager [instance: a52a12f7-190d-450c-9c1d-0b4aab066006] unit_number=unit_number)
2013-11-18 22:00:17.159 16297 TRACE nova.compute.manager [instance: a52a12f7-190d-450c-9c1d-0b4aab066006] File "/usr/lib/python2.6/site-packages/nova/virt/vmwareapi/volumeops.py", line 71, in attach_disk_to_vm
2013-11-18 22:00:17.159 16297 TRACE nova.compute.manager [instance: a52a12f7-190d-450c-9c1d-0b4aab066006] self._session._wait_for_task(instance_uuid, reconfig_task)
2013-11-18 22:00:17.159 16297 TRACE nova.compute.manager [instance: a52a12f7-190d-450c-9c1d-0b4aab066006] File "/usr/lib/python2.6/site-packages/nova/virt/vmwareapi/driver.py", line 900, in _wait_for_task
2013-11-18 22:00:17.159 16297 TRACE nova.compute.manager [instance: a52a12f7-190d-450c-9c1d-0b4aab066006] ret_val = done.wait()
2013-11-18 22:00:17.159 16297 TRACE nova.compute.manager [instance: a52a12f7-190d-450c-9c1d-0b4aab066006] File "/usr/lib/python2.6/site-packages/eventlet/event.py", line 116, in wait
2013-11-18 22:00:17.159 16297 TRACE nova.compute.manager [instance: a52a12f7-190d-450c-9c1d-0b4aab066006] ...

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/55070
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=8797aeaf14352a353ebfd1ed011f63a5b2fa3447
Submitter: Jenkins
Branch: master

commit 8797aeaf14352a353ebfd1ed011f63a5b2fa3447
Author: Gary Kotton <email address hidden>
Date: Sun Nov 3 02:14:39 2013 -0800

    VMware: fix rescue with disks are not hot-addable

    Some disks, for example IDE, cannot be attached to an instance
    when the instance is running.

    Change-Id: I3360066ea6406564caa328ec052b9e3ca9d63dc6
    Closes-Bug: #1247556

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/havana
Review: https://review.openstack.org/72542