Verify Networks doesn't wait long enough for dhcp response

Bug #1247284 reported by Brad Durrow
26
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
High
Dima Shulyak

Bug Description

We have a dhcp server on our "Public" network segment. Sometimes when we click the "Verify Networks" button we get Green "Verification succeeded. Your network is configured correctly." other times we get Red With messages about DHCP server found.

Brad Durrow (l-brad)
tags: added: system-tests ui
Brad Durrow (l-brad)
tags: added: astute
Mike Scherbakov (mihgen)
Changed in fuel:
assignee: nobody → Dima Shulyak (dshulyak)
Evgeniy L (rustyrobot)
Changed in fuel:
status: New → Confirmed
importance: Undecided → High
Revision history for this message
Dima Shulyak (dshulyak) wrote :

I refactored dhcp checker to allow it longer timeout.
So to close this bug we need to merge:
https://review.openstack.org/#/c/55278/
https://review.openstack.org/#/c/55380/
https://review.openstack.org/55383

Evgeniy L (rustyrobot)
Changed in fuel:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-astute (master)

Reviewed: https://review.openstack.org/55278
Committed: http://github.com/stackforge/fuel-astute/commit/800b91739f4b465bac1450862759be65db1ca56c
Submitter: Jenkins
Branch: master

commit 800b91739f4b465bac1450862759be65db1ca56c
Author: Dima <email address hidden>
Date: Tue Nov 5 16:27:00 2013 +0200

    Improve timeout for dhcp response waiter

    Dhcp checker tool is not always receives info
    on dhcp servers in network
    To make checking on network with 400 vlans it takes
    7 min to perform
    Also get_probing_info takes same time for this number of vlans

    Change-Id: I03cac773030ccfd6c6f433e117ea9240d787bbbe
    Closes-Bug: #1247284

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-astute (3.2-fixes)

Fix proposed to branch: 3.2-fixes
Review: https://review.openstack.org/59351

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-astute (3.2-fixes)

Reviewed: https://review.openstack.org/59351
Committed: http://github.com/stackforge/fuel-astute/commit/c981ba40fccfdb78be85fcff13188dfded2773ee
Submitter: Jenkins
Branch: 3.2-fixes

commit c981ba40fccfdb78be85fcff13188dfded2773ee
Author: Dima <email address hidden>
Date: Tue Nov 5 16:27:00 2013 +0200

    Improve timeout for dhcp response waiter

    Dhcp checker tool is not always receives info
    on dhcp servers in network
    To make checking on network with 400 vlans it takes
    7 min to perform
    Also get_probing_info takes same time for this number of vlans

    Change-Id: I03cac773030ccfd6c6f433e117ea9240d787bbbe
    Closes-Bug: #1247284

Mike Scherbakov (mihgen)
Changed in fuel:
milestone: none → 3.2.1
Revision history for this message
Evgeniy L (rustyrobot) wrote :
Changed in fuel:
milestone: 3.2.1 → 4.1
status: Fix Committed → Confirmed
assignee: Dima Shulyak (dshulyak) → Fuel Python Team (fuel-python)
status: Confirmed → Triaged
Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Aleksey Kasatkin (alekseyk-ru)
Changed in fuel:
status: Triaged → In Progress
Changed in fuel:
assignee: Aleksey Kasatkin (alekseyk-ru) → Roman Vyalov (r0mikiam)
Roman Vyalov (r0mikiam)
Changed in fuel:
assignee: Roman Vyalov (r0mikiam) → Fuel OSCI Team (fuel-osci)
Changed in fuel:
assignee: Fuel OSCI Team (fuel-osci) → Dima Shulyak (dshulyak)
Mike Scherbakov (mihgen)
tags: added: release-notes
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/55380
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=9bd1db420e8145b3e9dc7f1006b818022ba46d30
Submitter: Jenkins
Branch: master

commit 9bd1db420e8145b3e9dc7f1006b818022ba46d30
Author: Dima <email address hidden>
Date: Wed Nov 6 11:46:12 2013 +0200

    Refactor dhcp checker to use pcap

    Scapy packet filtering is slow and blocking.
    Pcap filtering can be used in same thread,
    this allows us to use higher timeout for dhcp offer waiting

    Setup proper logger for dhcp_checker app.
    ERROR level logs will be redirected to stderr
    DEBUG level to /var/log/dhcp_checker.log

    Change-Id: I7d9a0f1b8e3082637bc2474302fc0f7c17e0adb8
    Closes-Bug: #1247284

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-main (master)

Reviewed: https://review.openstack.org/55383
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=10767f7dfd1edac70731a05a8c8948d39a8cc073
Submitter: Jenkins
Branch: master

commit 10767f7dfd1edac70731a05a8c8948d39a8cc073
Author: Dima <email address hidden>
Date: Wed Nov 6 12:02:08 2013 +0200

    Refactor dhcp_checker spec to use pcap

    Add libpcap and python-pcap to dhcp_checker package

    Closes-Bug: #1247284

    Change-Id: I4a3c054cc26b0741874e111bc89272a5dddffcdd

Revision history for this message
Nastya Urlapova (aurlapova) wrote :

{
build_id: "2014-02-26_00-30-27",
mirantis: "yes",
build_number: "208",
nailgun_sha: "ea08cef3e06a72f47cfaa8cd8fe6d034e2cf722e",
ostf_sha: "8e6681b6d06c7cb20a84c1cc740d5f2492fb9d85",
fuelmain_sha: "7939e28a5b3ab65361991e2bc22a792c7561cf87",
astute_sha: "10cccc87f2ee35510e43c8fa19d2bf916ca1fced",
release: "4.1",
fuellib_sha: "0a2e5bdc01c1e3bb285acb7b39125101e950ac72"
}

Changed in fuel:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.