Not used 'Other Input' lines in payslip

[Katherine Zaoral (Vauxoo)]

I notice that the Other Input field in the payslip is not used when anywhere.
What is the use of these field?

[Katherine Zaoral (Vauxoo) (kathy-zaoral)]

Its not needed thar other input lines to be part of the Salary Computation fiel calculated by clicking the Compute Sheet button?
Assuming this I made this patch

[Amit Parik (amit-parik)]

Hello Katherine,

I think you might have misunderstood something, the other input comes from the salary rules, We don't have to manually enter it.
You can see on salary rules there is a input field where you have to enter the input code and description.

First you have to create the salary rules enter the inputs and used this inputs on python code of the rules. When you try to create the payslip then on the on_change of the employee you can see the other input fields value fill up via on_change method . After this you have to only enter the amount for this inputs and on the button compute sheet will calculate the payslip line correctly based on salary rule.

I have checked you patch but its not correct, because you have created the new lines on payslip line with the same amount on other inputs, when payslip lines generated based on other input.

The main aim for this other input field on payslip is used for calculate the commission and incentive etc, So for that we have to make the salary rules and It will calculate the respective commission and incentive. i.e If some employee sales the 10,000 per month and we can provide him a 1% of commission for sales amount. So via this fields we can manage it. You can see this things on attached video.

By the way are working correct here, No need to add the patch etc. So this is just your good question rather then a bug and I am going to covert into the question.

Thanks for the reporting and fell free to ask , If any issues.