python-novaclient: uses deprecated keyring.backend.$keyring

[Thomas Goirand]

Hi,

The following bug has been reported against my Debian package:
http://bugs.debian.org/728470

I'm doing a copy/past here of the content of the bug report. Please apply the patch provided on the Debian bug.

In python-keyring 1.1 the keyrings from keyring.backend have been moved into separate modules in keyring.backends and compatibility imports have been added in keyring.backend. In python-keyring 3.0 these compatibility imports have been removed. python-novaclient still uses keyrings from keyring.backend and needs to be adopted for the new naming scheme.

Please apply the attached patch to make python-novaclient compatible with python-keyring 3.0 and later. Please also adjust dependencies on python-keyring if necessary. python-keyring 3.2 is available in experimental so that you can test the patch.

Regards
Sebastian Ramacher

[Dmitry Shachnev (mitya57)]

Let me also copy-paste my comment on downstream bug (disclaimer: I am python-keyring co-developer):

The code in question is a hack needed to catch exceptions raised by python-gnomekeyring. However, modern python-keyring versions:

- Use GObject Introspection instead of python-gnomekeyring (since version 1.4, changeset e8e07ec);
- Handle such errors itself (since version 1.3, changeset 1e36608).

So I would recommend to just drop that hack as obsolete.

[Sahid Orentino (sahid-ferdjaoui)]

This bug is already fixed on master: https://review.openstack.org/#/c/58364/