AttributeError in Redis Matchmaker ack_alive()

[Rohit Karajgi]

The attribute name while re-registering a topic should be "self.host_topic" instead of "self.topic_host"
in https://github.com/openstack/nova/blob/master/nova/openstack/common/rpc/matchmaker_redis.py#L113

Otherwise, the following error is seen while starting the conductor service:
2013-10-30 18:02:32.849 ERROR nova.openstack.common.threadgroup [-] 'MatchMakerRedis' object has no attribute 'topic_host'
2013-10-30 18:02:32.849 TRACE nova.openstack.common.threadgroup Traceback (most recent call last):
2013-10-30 18:02:32.849 TRACE nova.openstack.common.threadgroup File "/opt/stack/nova/nova/openstack/common/threadgroup.py", line 117, in wait
2013-10-30 18:02:32.849 TRACE nova.openstack.common.threadgroup x.wait()
2013-10-30 18:02:32.849 TRACE nova.openstack.common.threadgroup File "/opt/stack/nova/nova/openstack/common/threadgroup.py", line 49, in wait
2013-10-30 18:02:32.849 TRACE nova.openstack.common.threadgroup return self.thread.wait()
2013-10-30 18:02:32.849 TRACE nova.openstack.common.threadgroup File "/usr/local/lib/python2.7/dist-packages/eventlet/greenthread.py", line 168, in
wait
2013-10-30 18:02:32.849 TRACE nova.openstack.common.threadgroup return self._exit_event.wait()
2013-10-30 18:02:32.849 TRACE nova.openstack.common.threadgroup File "/usr/local/lib/python2.7/dist-packages/eventlet/event.py", line 116, in wait
2013-10-30 18:02:32.849 TRACE nova.openstack.common.threadgroup return hubs.get_hub().switch()
2013-10-30 18:02:32.849 TRACE nova.openstack.common.threadgroup File "/usr/local/lib/python2.7/dist-packages/eventlet/hubs/hub.py", line 187, in swi
tch
2013-10-30 18:02:32.849 TRACE nova.openstack.common.threadgroup return self.greenlet.switch()
2013-10-30 18:02:32.849 TRACE nova.openstack.common.threadgroup File "/usr/local/lib/python2.7/dist-packages/eventlet/greenthread.py", line 194, in
main
2013-10-30 18:02:32.849 TRACE nova.openstack.common.threadgroup result = function(*args, **kwargs)
2013-10-30 18:02:32.849 TRACE nova.openstack.common.threadgroup File "/opt/stack/nova/nova/openstack/common/service.py", line 448, in run_service
2013-10-30 18:02:32.849 TRACE nova.openstack.common.threadgroup service.start()
2013-10-30 18:02:32.849 TRACE nova.openstack.common.threadgroup File "/opt/stack/nova/nova/service.py", line 176, in start
2013-10-30 18:02:32.849 TRACE nova.openstack.common.threadgroup self.conn.create_consumer(self.topic, rpc_dispatcher, fanout=False)
2013-10-30 18:02:32.849 TRACE nova.openstack.common.threadgroup File "/opt/stack/nova/nova/openstack/common/rpc/impl_zmq.py", line 578, in create_consumer
2013-10-30 18:02:32.849 TRACE nova.openstack.common.threadgroup _get_matchmaker().register(topic, CONF.rpc_zmq_host)
2013-10-30 18:02:32.849 TRACE nova.openstack.common.threadgroup File "/opt/stack/nova/nova/openstack/common/rpc/matchmaker.py", line 207, in register
2013-10-30 18:02:32.849 TRACE nova.openstack.common.threadgroup self.ack_alive(key, host)
2013-10-30 18:02:32.849 TRACE nova.openstack.common.threadgroup File "/opt/stack/nova/nova/openstack/common/rpc/matchmaker_redis.py", line 113, in ack_alive
2013-10-30 18:02:32.849 TRACE nova.openstack.common.threadgroup self.register(self.topic_host[host], host)
2013-10-30 18:02:32.849 TRACE nova.openstack.common.threadgroup AttributeError: 'MatchMakerRedis' object has no attribute 'topic_host'

[Davanum Srinivas (DIMS) (dims-v)]

Rohit,

Needs to be fixed in Oslo first:
https://github.com/openstack/oslo-incubator/blob/master/openstack/common/rpc/matchmaker_redis.py#L113
https://github.com/openstack/oslo.messaging/blob/master/oslo/messaging/_drivers/matchmaker_redis.py#L114

-- dims

[Rohit Karajgi (rohitk)]

dims: agreed.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/54555

[Matt Riedemann (mriedem)]

Not sure if this is still an issue but it needs to be fixed in oslo.messaging first and the proposed patch was abandoned awhile ago.

[Ben Nemec (bnemec)]

Yeah, the zmq driver is very, very broken right now, from what I understand anyway. TBD whether it's going to be fixed or removed. We had a couple of people at summit say they were interested in working on it, but I'm not sure that went anywhere.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/129114
Committed: https://git.openstack.org/cgit/openstack/oslo.messaging/commit/?id=6987b8ac288c16c141b6872b711754d204223400
Submitter: Jenkins
Branch: master

commit 6987b8ac288c16c141b6872b711754d204223400
Author: Li Ma <email address hidden>
Date: Thu Oct 16 19:52:04 2014 -0700

    Fix incorrect attribute name in matchmaker_redis

    Pass the correct base class attribute name for host topic to
    self.register and fix the AttributeError.

    Change-Id: Idfe94dd37cdba9f498f79cf87d4fff81e7c4249b
    Closes-Bug: #1246308