""No attribute error" from get_v4_ips_by_interface in n-net log after successful tempest run

[David Kranz]

From console log:

https://review.openstack.org/#/c/54405/2
http://logs.openstack.org/05/54405/2/check/check-tempest-devstack-vm-postgres-full/16caec6
2013-10-29 20:08:54.485 | Log File: n-net
2013-10-29 20:08:54.486 | 2013-10-29 19:51:53.722 ERROR nova.openstack.common.rpc.amqp [req-6350fb63-cae4-44a9-8372-70b0bbcec4bf None None] Exception during message handling
2013-10-29 20:08:54.486 |
2013-10-29 20:08:54.507 | 2013-10-29 19:51:53.724 ERROR nova.openstack.common.rpc.common [req-6350fb63-cae4-44a9-8372-70b0bbcec4bf None None] Returning exception 'NoneType' object has no attribute '__getitem__' to caller
2013-10-29 20:08:54.508 |
2013-10-29 20:08:54.508 | 2013-10-29 19:51:53.724 ERROR nova.openstack.common.rpc.common [req-6350fb63-cae4-44a9-8372-70b0bbcec4bf None None] ['Traceback (most recent call last):\n', ' File "/opt/stack/new/nova/nova/openstack/common/rpc/amqp.py", line 461, in _process_data\n **args)\n', ' File "/opt/stack/new/nova/nova/openstack/common/rpc/dispatcher.py", line 172, in dispatch\n result = getattr(proxyobj, method)(ctxt, **kwargs)\n', ' File "/opt/stack/new/nova/nova/openstack/common/rpc/common.py", line 439, in inner\n return catch_client_exception(exceptions, func, *args, **kwargs)\n', ' File "/opt/stack/new/nova/nova/openstack/common/rpc/common.py", line 420, in catch_client_exception\n return func(*args, **kwargs)\n', ' File "/opt/stack/new/nova/nova/network/manager.py", line 582, in get_instance_nw_info\n rxtx_factor, host)\n', ' File "/opt/stack/new/nova/nova/network/manager.py", line 617, in build_network_info_model\n network[\'project_id\'])\n', ' File "/opt/stack/new/nova/nova/network/nova_ipam_lib.py", line 78, in get_v4_ips_by_interface\n vif_rec[\'id\'])\n', "TypeError: 'NoneType' object has no attribute '__getitem__'\n"]
2013-10-29 20:08:54.509 |

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/54455
Committed: http://github.com/openstack/nova/commit/c62b1fcd84e084083654e131360a8c01752a5606
Submitter: Jenkins
Branch: master

commit c62b1fcd84e084083654e131360a8c01752a5606
Author: Davanum Srinivas <email address hidden>
Date: Tue Oct 29 20:50:05 2013 -0400

    Fix AttributeError(s) from get_v4/6_ips_by_interface

    Add some defensive code to prevent AttributeError especially
    when virtual_interface_get_by_uuid returns None. Add some basic
    tests for good and bad data returned from
    virtual_interface_get_by_uuid

    Change-Id: I0ee1bb2087a6ed2619ac343534e4ade84e08d9bd
    Closes-Bug: 1246087