RouterGateway isn't a thing

[Zane Bitter]

Heat includes an OS::Neutron::RouterGateway resource that represents the connection between a router and the network on which its gateway resides.

This should not be modelled as a separate resource type. Doing so causes the dependency problems that require hacks to get things to build in the right order:
https://review.openstack.org/#/c/29857/
https://review.openstack.org/#/c/29858/

The gateway network should simply be a property of a Router, as it is in the Neutron API (add_gateway_router() just updates the 'external_gateway_info' attribute of a router).

So we need to:
* Add a property to the OS::Neutron::Router resource type to allow the external_gateway_info to be set
* Deprecate the RouterGateway resource with a view to removing it
* Eventually, delete the resource type and its related hacks

[Rupak Ganguly (rupakg)]

Totally agreed.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/60118

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/60118
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=6929d020eb542995c187f9fecd206c1aeb95d235
Submitter: Jenkins
Branch: master

commit 6929d020eb542995c187f9fecd206c1aeb95d235
Author: Bartosz Górski <email address hidden>
Date: Tue Nov 26 12:35:25 2013 -0800

    Add an external gateway property to neutron router

    Deprecates existing RouterGateway resource and adds external_gateway property
    to neutron Router resource to set up the gateway.

    Change-Id: Ic61a817e699d2a005c4eb2c5d7b23ae9a70567c0
    Closes-Bug: #1246064