Remove admin checks from database layer

Bug #1245952 reported by andersonvom
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Heat
Fix Released
Medium
andersonvom

Bug Description

There are admin checks inside the database layer (heat/db/sqlalchemy/api.py) that should be performed elsewhere.

It looks like this admin check is being used only in one place (EngineService#_check_stack_watches in heat/engine/service.py) and was meant to be a quick fix for another feature.

The DB layer should be concerned with data retrieval only.

Revision history for this message
Clint Byrum (clint-fewbar) wrote :

Agreed, thanks for the bug report!

Changed in heat:
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to heat (master)

Fix proposed to branch: master
Review: https://review.openstack.org/54395

Changed in heat:
assignee: nobody → andersonvom (andersonvom)
status: Triaged → In Progress
Steven Hardy (shardy)
Changed in heat:
milestone: none → icehouse-1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to heat (master)

Reviewed: https://review.openstack.org/54395
Committed: http://github.com/openstack/heat/commit/3dead2a0811d83b701ad2d9aac9713b2f426d256
Submitter: Jenkins
Branch: master

commit 3dead2a0811d83b701ad2d9aac9713b2f426d256
Author: Anderson Mesquita <email address hidden>
Date: Wed Oct 30 14:11:33 2013 -0500

    Rename admin flag on SqlAlchemy#stack_get

    The `admin` flag was only used to avoid doing a tenant_id check between
    the stack and the context.tenant_id, so it was renamed to `tenant_safe`
    for better clarity.

    Change-Id: I32c1156c8782bad39a265c77aad088c96400f69f
    Closes-Bug: 1245952

Changed in heat:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in heat:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in heat:
milestone: icehouse-1 → 2014.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.