[7.0/trunk] last_reconcile_date field usage in manual reconcile defective by design

[Frederic Clementi - Camptocamp]

The field 'last_reconcile_date' is on the partner form. Every time I post a new accounting move line with a specific partner and an account ' , this date is updated.

Problem I see is that you can have more than 1 account 'allow reconcile = true' for a specific partner so having such a date on partner is not correct since it is the couple 'account + partner' which is relevant to update this date.
This create a lot of problems/confusions when users want to do manual reconciliation.

Let me give an example :
Knowing that account 1234 is 'allow reconcile = true'
and account 5678 is also 'allow reconcile = true'

If I post an entry on Partner X - account 1234 -> last_reconcile_date on partner X will be updated
-> Consequence : in accounting menu 'Manual reconciliation', if I filter on account 1234 and partner X and then click on 'Nothing to reconcile' all lines are not displayed anymore (imagine that I do not want to do reconciliation for now but I consider this as ok and I do not want to see these lines until next accounting posting on this account and partner)

Now I post an entry on Partner X - account 5678 -> last_reconcile_date will be updated
-> Consequence : in accounting menu 'Manual reconciliation', if I filter on account 1234 (and not 5678) and partner X, all my lines are visible again whereas I previously click on nothing to reconcile.

What I want to demonstrate is that 'last_reconcile_date' field should never be on the partner (probably rather on the reconcile and partial reconcile like the field last_rec_date in the module account_financial_report_webkit)...

So I ask you to consider this is issue at least in trunk.

Frederic