Upgrader should check for tools before downloading
Bug #1245770 reported by
John A Meinel
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
juju-core |
Fix Released
|
High
|
John A Meinel |
Bug Description
When we moved the Upgrader over to the API we lost the check if the tools already existed in the target.
In 1.16 when Upgrader sees that an Upgrade is needed, it *always* downloads the tools, extracts them, and only after doing all that work does it notice that the tools already exist.
The old Upgrader code had a check just before download if the target tools could be read already. Arguably we could check before we download, and then one more time between downloading the tools and actually extracting them (since it takes time to actually do the download).
Related branches
lp:~jameinel/juju-core/read-before-download
- Juju Engineering: Pending requested
-
Diff: 62 lines (+26/-2)3 files modifiedworker/upgrader/export_test.go (+8/-0)
worker/upgrader/upgrader.go (+6/-2)
worker/upgrader/upgrader_test.go (+12/-0)
tags: | added: performance |
Changed in juju-core: | |
milestone: | none → 1.17.0 |
Changed in juju-core: | |
status: | In Progress → Fix Committed |
Changed in juju-core: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.