nova boot via invalid neutron port raises 500

[Aaron Rosen]

2013-10-28 15:46:38.470 ERROR nova.api.openstack [req-e405f8e2-95a1-4748-8f9f-c642080e16b3 demo demo] Caught error: local variable 'port' referenced before assignment
2013-10-28 15:46:38.470 TRACE nova.api.openstack Traceback (most recent call last):
2013-10-28 15:46:38.470 TRACE nova.api.openstack File "/opt/stack/nova/nova/api/openstack/__init__.py", line 119, in __call__
2013-10-28 15:46:38.470 TRACE nova.api.openstack return req.get_response(self.application)
2013-10-28 15:46:38.470 TRACE nova.api.openstack File "/usr/lib/python2.7/dist-packages/webob/request.py", line 1296, in send
2013-10-28 15:46:38.470 TRACE nova.api.openstack application, catch_exc_info=False)
2013-10-28 15:46:38.470 TRACE nova.api.openstack File "/usr/lib/python2.7/dist-packages/webob/request.py", line 1260, in call_application
2013-10-28 15:46:38.470 TRACE nova.api.openstack app_iter = application(self.environ, start_response)
2013-10-28 15:46:38.470 TRACE nova.api.openstack File "/usr/lib/python2.7/dist-packages/webob/dec.py", line 144, in __call__
2013-10-28 15:46:38.470 TRACE nova.api.openstack return resp(environ, start_response)
2013-10-28 15:46:38.470 TRACE nova.api.openstack File "/opt/stack/python-keystoneclient/keystoneclient/middleware/auth_token.py", line 571, in __call__
2013-10-28 15:46:38.470 TRACE nova.api.openstack return self.app(env, start_response)
2013-10-28 15:46:38.470 TRACE nova.api.openstack File "/usr/lib/python2.7/dist-packages/webob/dec.py", line 144, in __call__
2013-10-28 15:46:38.470 TRACE nova.api.openstack return resp(environ, start_response)
2013-10-28 15:46:38.470 TRACE nova.api.openstack File "/usr/lib/python2.7/dist-packages/webob/dec.py", line 144, in __call__
2013-10-28 15:46:38.470 TRACE nova.api.openstack return resp(environ, start_response)
2013-10-28 15:46:38.470 TRACE nova.api.openstack File "/usr/lib/python2.7/dist-packages/routes/middleware.py", line 131, in __call__
2013-10-28 15:46:38.470 TRACE nova.api.openstack response = self.app(environ, start_response)
2013-10-28 15:46:38.470 TRACE nova.api.openstack File "/usr/lib/python2.7/dist-packages/webob/dec.py", line 144, in __call__
2013-10-28 15:46:38.470 TRACE nova.api.openstack return resp(environ, start_response)
2013-10-28 15:46:38.470 TRACE nova.api.openstack File "/usr/lib/python2.7/dist-packages/webob/dec.py", line 130, in __call__
2013-10-28 15:46:38.470 TRACE nova.api.openstack resp = self.call_func(req, *args, **self.kwargs)
2013-10-28 15:46:38.470 TRACE nova.api.openstack File "/usr/lib/python2.7/dist-packages/webob/dec.py", line 195, in call_func
2013-10-28 15:46:38.470 TRACE nova.api.openstack return self.func(req, *args, **kwargs)
2013-10-28 15:46:38.470 TRACE nova.api.openstack File "/opt/stack/nova/nova/api/openstack/wsgi.py", line 939, in __call__
2013-10-28 15:46:38.470 TRACE nova.api.openstack content_type, body, accept)
2013-10-28 15:46:38.470 TRACE nova.api.openstack File "/opt/stack/nova/nova/api/openstack/wsgi.py", line 998, in _process_stack
2013-10-28 15:46:38.470 TRACE nova.api.openstack action_result = self.dispatch(meth, request, action_args)
2013-10-28 15:46:38.470 TRACE nova.api.openstack File "/opt/stack/nova/nova/api/openstack/wsgi.py", line 1079, in dispatch
2013-10-28 15:46:38.470 TRACE nova.api.openstack return method(req=request, **action_args)
2013-10-28 15:46:38.470 TRACE nova.api.openstack File "/opt/stack/nova/nova/api/openstack/compute/servers.py", line 924, in create
2013-10-28 15:46:38.470 TRACE nova.api.openstack legacy_bdm=legacy_bdm)
2013-10-28 15:46:38.470 TRACE nova.api.openstack File "/opt/stack/nova/nova/hooks.py", line 105, in inner
2013-10-28 15:46:38.470 TRACE nova.api.openstack rv = f(*args, **kwargs)
2013-10-28 15:46:38.470 TRACE nova.api.openstack File "/opt/stack/nova/nova/compute/api.py", line 1218, in create
2013-10-28 15:46:38.470 TRACE nova.api.openstack legacy_bdm=legacy_bdm)
2013-10-28 15:46:38.470 TRACE nova.api.openstack File "/opt/stack/nova/nova/compute/api.py", line 859, in _create_instance
2013-10-28 15:46:38.470 TRACE nova.api.openstack block_device_mapping, auto_disk_config, reservation_id)
2013-10-28 15:46:38.470 TRACE nova.api.openstack File "/opt/stack/nova/nova/compute/api.py", line 673, in _validate_and_build_base_options
2013-10-28 15:46:38.470 TRACE nova.api.openstack self._check_requested_networks(context, requested_networks)
2013-10-28 15:46:38.470 TRACE nova.api.openstack File "/opt/stack/nova/nova/compute/api.py", line 437, in _check_requested_networks
2013-10-28 15:46:38.470 TRACE nova.api.openstack self.network_api.validate_networks(context, requested_networks)
2013-10-28 15:46:38.470 TRACE nova.api.openstack File "/opt/stack/nova/nova/network/neutronv2/api.py", line 553, in validate_networks
2013-10-28 15:46:38.470 TRACE nova.api.openstack if not port:
2013-10-28 15:46:38.470 TRACE nova.api.openstack UnboundLocalError: local variable 'port' referenced before assignment

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/54211

[Aaron Rosen (arosen)]

Actually the nova code can be made slightly more robust here.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/54219
Committed: http://github.com/openstack/nova/commit/2392f746d31028dca5fdf6de423f807bfaf69c84
Submitter: Jenkins
Branch: master

commit 2392f746d31028dca5fdf6de423f807bfaf69c84
Author: Aaron Rosen <email address hidden>
Date: Mon Oct 28 18:05:15 2013 -0700

    Correct exception handling

    Previously, it was possible for an exception to be hidden and cause other
    errors for example:
        UnboundLocalError: local variable 'port' referenced before assignment
    was previously occuring if e.status_code != 404

    Fixes bug: 1245700

    Change-Id: I27e44ffd33a73c88745de8fda8fd7c374435808a

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/54211
Committed: http://github.com/openstack/python-neutronclient/commit/feda92ff0b28514b27e8e05713368962366c9fa4
Submitter: Jenkins
Branch: master

commit feda92ff0b28514b27e8e05713368962366c9fa4
Author: Aaron Rosen <email address hidden>
Date: Mon Oct 28 16:33:27 2013 -0700

    Fix status_code not passed in code

    The python-neutronclient was refactored to raise NeutronClientException
    and when that occured the status_code field was dropped. This causes errors
    on the nova-side to occur as nova checks the status_code to do error handling.

    Fixes bug: 1245700

    Change-Id: Ie1fcf3fef0e20c33ce18549bca6a2413a9f98e9f